Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shared/net: fix SplitHostPort() to allow portless strings #83

Merged
merged 1 commit into from
Mar 18, 2023

Conversation

amery
Copy link
Contributor

@amery amery commented Mar 17, 2023

No description provided.

@amery amery changed the title shared/net: fix SplitHostPort() to allow portness strings shared/net: fix SplitHostPort() to allow portless strings Mar 17, 2023
@amery amery requested a review from karasz March 17, 2023 21:24
Signed-off-by: Alejandro Mery <amery@jpi.io>
Copy link
Collaborator

@karasz karasz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@karasz karasz merged commit c14a20f into master Mar 18, 2023
@karasz karasz deleted the pr-amery-splithostport branch March 18, 2023 08:50
@amery
Copy link
Contributor Author

amery commented Mar 18, 2023

shared/v0.4.5 tagged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants