-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tls: introduce Store instead and NewConfig/WithStore helper #105
Conversation
WalkthroughThe changes introduce two new files in the Changes
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (2)
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Here's the code health analysis summary for commits Analysis Summary
|
@CodiumAI-Agent /review |
PR Reviewer Guide 🔍(Review updated until commit 48a0a44)Here are some key observations to aid the review process:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 4
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (2)
- tls/std.go (1 hunks)
- tls/store.go (1 hunks)
✅ Files skipped from review due to trivial changes (1)
- tls/std.go
383b48d
to
ed2ac23
Compare
Signed-off-by: Alejandro Mery <amery@apptly.co>
to help setting up a [tls.Config] Signed-off-by: Alejandro Mery <amery@apptly.co>
ed2ac23
to
48a0a44
Compare
rebased |
Persistent review updated to latest commit 48a0a44 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, although TLS12 is the default minimal version in golang
Summary by CodeRabbit
Store
interface for managing TLS settings, including methods for retrieving certificates and CA pools.Store
instance to TLS configurations and create new TLS configurations with predefined settings.