-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Benchmark pallet_bridge_parachains
and pallet_bridge_messages
#1158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AurevoirXavier
added
C-Test
[Component] Something about test
C-Runtime
[Component] Something about runtime
labels
Jun 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Waiting for darwinia-network/darwinia-messages-substrate#270 and companion to thepolkadot-v0.9.40
branch.A note to the reviewer:
The benchmark implementation in the darwinia-message-substrate
pallet-bridge-messages
is based on the solo chain instead of the parachain. To make the benchmark work, we need to useverify_messages_proof
intead ofverify_messages_proof_from_parachain
, otherwise, the message proof verification will fail. Of course, another way is to assign the message benchmark script to the upstream repo, usingverify_messages_proof_from_parachain
, that means we need to make big changes to the current darwinia-messages-substrate repo. Considering the future plan of this repo, we can keep things simpler for now.To make the benchmark call dispatch successful, the
spec_versio
n required to be the same as the hard-coded one in the messsage benchmark script. So introduced anotherVERSION
under benchmark feature.