Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Benchmark pallet_bridge_parachains and pallet_bridge_messages #1158

Merged
merged 15 commits into from
Jun 5, 2023

Conversation

boundless-forest
Copy link
Member

@boundless-forest boundless-forest commented May 24, 2023

Waiting for darwinia-network/darwinia-messages-substrate#270 and companion to the polkadot-v0.9.40 branch.

A note to the reviewer:

The benchmark implementation in the darwinia-message-substrate pallet-bridge-messages is based on the solo chain instead of the parachain. To make the benchmark work, we need to use verify_messages_proof intead of verify_messages_proof_from_parachain, otherwise, the message proof verification will fail. Of course, another way is to assign the message benchmark script to the upstream repo, usingverify_messages_proof_from_parachain, that means we need to make big changes to the current darwinia-messages-substrate repo. Considering the future plan of this repo, we can keep things simpler for now.

To make the benchmark call dispatch successful, the spec_version required to be the same as the hard-coded one in the messsage benchmark script. So introduced another VERSION under benchmark feature.

@boundless-forest boundless-forest marked this pull request as ready for review May 29, 2023 05:53
@AurevoirXavier AurevoirXavier added C-Test [Component] Something about test C-Runtime [Component] Something about runtime labels Jun 5, 2023
@AurevoirXavier AurevoirXavier merged commit 3456b73 into main Jun 5, 2023
@AurevoirXavier AurevoirXavier deleted the bear-fix-messages-parachains-benchmark branch June 5, 2023 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-Runtime [Component] Something about runtime C-Test [Component] Something about test
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Update the pallet_bridge_parachains and pallet_bridge_messages weight info
2 participants