Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QDataSet.CADENCE_MIN and QDataSet.CADENCE_MAX introduction #41

Open
jbfaden opened this issue Nov 19, 2022 · 3 comments
Open

QDataSet.CADENCE_MIN and QDataSet.CADENCE_MAX introduction #41

jbfaden opened this issue Nov 19, 2022 · 3 comments

Comments

@jbfaden
Copy link
Member

jbfaden commented Nov 19, 2022

I've been thinking about adding QDataSet.CADENCE_MIN and QDataSet.CADENCE_MAX, which would be alternatives to QDataSet.CADENCE. This would fix a problem were sometimes you want to know an upper or a lower limit, and this would allow codes and datasets to support this. I've always imagined that QDataSet.CADENCE might be allowed to be a rank 1 dataset, and this might be a better solution here as well.

As with any QDataSet property, any property can be missing, and the three must be considered as group now, CADENCE_MIN=CADENCE_MAX -> CADENCE=CADENCE_MIN, etc.

@jbfaden
Copy link
Member Author

jbfaden commented Jul 7, 2023

CADENCE_MAX would be used for interpolation, CADENCE_MIN would be used for extrapolation.

@jbfaden
Copy link
Member Author

jbfaden commented Jul 26, 2023

Note some care is needed with CADENCE_MAX or CADENCE_MIN being missing while CADENCE is present. If CADENCE_MAX is missing, does it mean that CADENCE should be used, or that there's no apparent CADENCE_MAX? How about with CADENCE_MIN?

@jbfaden
Copy link
Member Author

jbfaden commented Dec 9, 2023

I was just running into an issue with one of the guessCadence codes, this one where I try to use GCD of the diffs: DataSetUtil.guessCadence. There really needs to be a solid definition of cadence and a solid routine to identify it.

jbfaden added a commit that referenced this issue Dec 9, 2023
where the cadence guess fails because gcd code fails.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant