-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Edit lists routes (DSP-597 ) #1753
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…h-swiss/knora-api into wip/DSP-597-EditListsRoutes
…e IRI or to get a node given nodeIri
…name of the node individually
benjamingeer
approved these changes
Nov 18, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent, thanks very much!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves DSP-597 and resolves DSP-1070
PUT admin/lists/<listItemIri>/name
to update name of a list or child node.PUT admin/lists/<listItemIri>/labels
to update labels of a list or child node.PUT admin/lists/<listItemIri>/comments
to update comments of a list or child node.Under new-list-admin-routes:1 toggle:
Post(admin/lists)
for creating root (i.e. list) or child node.Put(admin/lists/<listItemIri>)
to modify root node (i.e. list) or a child nodeGet(admin/lists/<listItemIri>)
to get root node (i.e. list) or a child nodeGet(admin/lists/<listItemIri>/info)
to get node information (without children) of a root or child node and remove the redundent routeGET(admin/lists/nodes/<nodeIri>)
Note: the swagger problem will be fixed in a separate PR.