Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit lists routes (DSP-597 ) #1753

Merged
merged 33 commits into from
Nov 18, 2020
Merged

Edit lists routes (DSP-597 ) #1753

merged 33 commits into from
Nov 18, 2020

Conversation

SepidehAlassi
Copy link
Contributor

@SepidehAlassi SepidehAlassi commented Nov 6, 2020

resolves DSP-597 and resolves DSP-1070

  • Use one responder for creating node (root or child)
  • Use one responder for updating node info (root or child), resolves issue Edit list item #1387
  • Use one responder for getting entire node (root or child) with children.
  • Use one responder for getting node info (root or child), i.e. response does not contain children
  • add new routes for
  • PUT admin/lists/<listItemIri>/name to update name of a list or child node.
  • PUT admin/lists/<listItemIri>/labels to update labels of a list or child node.
  • PUT admin/lists/<listItemIri>/comments to update comments of a list or child node.
  • Add tests

Under new-list-admin-routes:1 toggle:

  • Use Post(admin/lists) for creating root (i.e. list) or child node.
  • Use Put(admin/lists/<listItemIri>) to modify root node (i.e. list) or a child node
  • Use Get(admin/lists/<listItemIri>) to get root node (i.e. list) or a child node
  • Use Get(admin/lists/<listItemIri>/info)to get node information (without children) of a root or child node and remove the redundent route GET(admin/lists/nodes/<nodeIri>)
  • Add new set of E2E tests
  • Add new documentation

Note: the swagger problem will be fixed in a separate PR.

@subotic subotic added the enhancement improve existing code or new feature label Nov 6, 2020
@SepidehAlassi SepidehAlassi marked this pull request as ready for review November 17, 2020 18:49
Copy link

@benjamingeer benjamingeer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent, thanks very much!

@SepidehAlassi SepidehAlassi merged commit 54f107d into main Nov 18, 2020
@SepidehAlassi SepidehAlassi deleted the wip/DSP-597-EditListsRoutes branch November 18, 2020 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement improve existing code or new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants