Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Redundant list routes? #1528

Closed
benjamingeer opened this issue Nov 27, 2019 · 2 comments · Fixed by #1727
Closed

Redundant list routes? #1528

benjamingeer opened this issue Nov 27, 2019 · 2 comments · Fixed by #1727
Assignees
@subotic @SepidehAlassi
Labels
API/Admin question further information is requested

Comments

@benjamingeer
Copy link

I think these two routes are the same:

Is that correct? If so, the client API only needs to implement one of them.
@benjamingeer benjamingeer added the question further information is requested label Nov 27, 2019
@subotic
Copy link
Collaborator

subotic commented Nov 27, 2019

Thanks for reporting!

@LukasStoeckli is kindly taking over the work on lists. There is an open PR #1447 and there it looks like the redundancy is not present anymore. But he will surely check to be sure.

@benjamingeer benjamingeer mentioned this issue Nov 27, 2019
Merged
@benjamingeer
Copy link
Author

OK. It looks like the existing requests and responses in the lists route are changing in #1447, so I will pause work on #1509 until #1447 is merged.

@subotic subotic mentioned this issue Dec 13, 2019
Closed
@subotic subotic added this to the Backlog milestone Feb 7, 2020
@SepidehAlassi SepidehAlassi mentioned this issue Oct 7, 2020
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@subotic subotic

@SepidehAlassi SepidehAlassi

Labels
API/Admin question further information is requested
Projects
None yet
Milestone
No milestone
4 participants
@subotic @benjamingeer @SepidehAlassi @LukasStoeckli