DSP-369 System Prop Info #157
Conversation
| @@ -123,6 +123,10 @@ export class DisplayEditComponent implements OnInit { | |||
| this.readOnlyValue = this._valueTypeService.isReadOnly(this.valueTypeOrClass); | |||
| } | |||
|
|
|||
| getTooltipText(): string { | |||
| return 'Value creation date: ' + this.displayValue.valueCreationDate + '\n Attached to user: ' + this.displayValue.attachedToUser; | |||
There was a problem hiding this comment.
does a newline take any effect in html?
There was a problem hiding this comment.
but isn't it treated like a newline (rather than an actual line break)?
There was a problem hiding this comment.
ah yeah, it doesn't generate a <br>. Here's the generated HTML:
|
|
||
| getTooltipText(): string { | ||
| return 'Value creation date: ' + this.displayValue.valueCreationDate + | ||
| '\n Attached to user: ' + this.user?.givenName + ' ' + this.user?.familyName; |
There was a problem hiding this comment.
I would keep the labels simple: "Creation date" + "Value owner" or "Value creator".
According to the knora docs, attachedToUser = The user who owns the value. You can pick the most appropriate term in English.
There was a problem hiding this comment.
I agree with "Creation date" and "Value creator" 👍
"Value owner" can confuse users especially when the value is created by an import script. In this case the owner is a bot or an import user. This will drive people crazy 🤪
There was a problem hiding this comment.
fixed in 77aaefd. Apparently the new line character never actually worked. It was just a coincidence that the line broke at the correct place. I needed to add white-space: pre-line to the tooltip class in dsp-ui.scss.
| @@ -31,6 +31,12 @@ | |||
| (click)="activateEditMode()"> | |||
| <mat-icon>edit</mat-icon> | |||
| </button> | |||
| <button mat-button | |||
There was a problem hiding this comment.
I am wondering if this information should not also be readable in read mode..
@kilchenmann what do you think? how was it in Salsah?
There was a problem hiding this comment.
I do not understand: What information is meant here?
There was a problem hiding this comment.
here there are Creation date and Value creator. Do we need to display other kind of information?
There was a problem hiding this comment.
Ah I see...it's the creation date and value creator etc
There was a problem hiding this comment.
This information does not exist in SALSAH; Neither on the resource nor on the propert.
Here's a resource view:
https://data.dasch.swiss/resources/2632709
There was a problem hiding this comment.
What about also having the value comment button show on hover? I just realized there is no way to see the comment in read mode currently.
There was a problem hiding this comment.
ah yes I think it is important to have it in read mode, and if I've understood correctly, it is possible that a user can have the permission to create/edit a value comment but does not have the permission to create/edit/delete a value.... but this is another issue. @kilchenmann what do you think?
There was a problem hiding this comment.
it is possible that a user can have the permission to create/edit a value comment but does not have the permission to create/edit/delete a value.... but this is another issue.
Yes this should be solved in a separate PR.
There was a problem hiding this comment.
4d93d5e enables the property info and comment hover buttons in read mode
There was a problem hiding this comment.
it is possible that a user can have the permission to create/edit a value comment but does not have the permission to create/edit/delete a value.... but this is another issue.
Yes this should be solved in a separate PR.
@flavens I've created a user story for this and added it to the dsp-ui roadmap. Not sure when we'll get around to it.
https://dasch.myjetbrains.com/youtrack/issue/DSP-683
… css so that the line breaks within tooltips work correctly now
…mment hover icons in read mode
closes https://dasch.myjetbrains.com/youtrack/issue/DSP-369