-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DSP-623 Color Value Polish #191
Conversation
… the color picker
…ue comp and added placeholder to color-picker comp
…com/dasch-swiss/dsp-ui-lib into wip/dsp-623-color-value-comp-polish
@mdelez What do you think? Is it done? Can someone do the review? |
I think the only thing I would still try to do is to center the placeholder text in the middle of the box but I know it's not very easy as I've tried as well. Other than that, it looks great! You can request a review and see what the others have to say? |
Yes, I also wanted to center it. But it was not possible with my previous settings. I can try again.... |
It's not a big issue so don't stress too much over it :) |
It's not possible to center the label, as this also affects the comment input field. |
No worries :) You can request a review from Flavie since she was the one who originally created this component. |
@@ -1 +1,6 @@ | |||
@import "../../../../../assets/style/viewer"; | |||
|
|||
::ng-deep .mat-form-field-flex, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
instead of using ::ng-deep
, would it be possible to do it in one of the main stylesheets (src/assets/style/*)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is what I always suggested. I can move it to ds-ui.scss...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you move this to dsp-ui.scss, then this will be applied to every .mat-form-field-flex in the DOM. I think I originally tried to do this in dsp-ui.scss and select it via a class name but it wasn't working.
But this is a topic that is also not so clear to me. From the dsp-ui.scss, I expect to be able to reach any element/class in the DOM but it seems like my ability to select elements/classes inside other elements/classes is cut off at a certain point.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mdelez Yes I know. But I will use the component tag name as first selector then it should work. I'm not sure...I will try
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm actually dealing with this same CSS scenario in this PR. I've found that within dsp-ui.scss, I can select custom class names as expected. However the issue arrises when I try to do the same thing in _viewer.scss. Do you know why I am not able to do this in _viewer.scss?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
well, shouldn't we keep it consistent with the other css files? or is it something different?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mdelez Do you want to push your solution? Mine is not well done, I think...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is the decision between :host
and ::ng-deep
in the the color value scss file? If so, I would choose :host
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I pushed it, but not the thing with :host
the host is bigger than the input and the pointer was not only inside the box.
@mdelez You can still override my solution and/or re-request a review
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
aha, what you did looks good :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kilchenmann why is there such a big gap between the color field and the comment field in edit and create modes?
|
|
closes https://dasch.myjetbrains.com/youtrack/issue/DSP-623
uses dsp-js rc.11 and dsp-api rc.15