DSP-682 Integrate Ckeditor into Property View

[mdelez]

resolves DSP-682

ValueTypeService.isReadOnly has a a second required param now: isReadOnly(valueTypeOrClass: string, value: ReadValue): boolean

[mdelez]

@tobiasschweizer here is what I have so far, including broken tests 😄

[tobiasschweizer]

TODOs:

• if the XML text value uses the standard mapping, treat it as if it were HTML in read-mode (links should clickable, formatting is rendered)

• if the XML text value uses the standard mapping, it can be edited by the user, the necessary permissions provided

• for all other XML text values, show the XML source in read-mode

• whitespace issues should be dealt with in the XML component directly, not in the base class's standard validator. It would possible to override the standardValueComparisonFunc in the XML text value component as we do already for complex values like intervals etc.

• since we only support editing of XML text values using the standard mapping, the XML conversion needed for compatibility reasons should be moved from the config object into the component itself, but be centralised there, so that the conversion works both ways. Before passing the XML to CKEditor, the conversion should be applied because otherwise the validation does not work properly (comparison of init value).

• callback for internal url condition should check if url is null
  return !!url && url.startsWith(this.resourceBasePath);

• css for read-mode should be adapted to remove the margin around paragraphs

• implement support for adding a new XML value

[tobiasschweizer]

Conversion fun:

"xmlTransform": {
    "http://rdfh.ch/standoff/mappings/StandardMapping": {
      "<hr>": "<hr/>",
      "</hr>": "",
      "<s>": "<strike>",
      "</s>": "</strike>",
      "<i>": "<em>",
      "</i>": "</em>",
      "<figure class=\"table\">": "",
      "</figure>": ""
    }
  }

Maybe we could make the CKEditor instance return the internally converted markup, so we could use it as the initial value.

Maybe related: https://ckeditor.com/docs/ckeditor5/latest/framework/guides/deep-dive/conversion/conversion-preserving-custom-content.html

[tobiasschweizer]

@mdelez Could you have a look at 2627050? I had to adapt some expectations in the tests.

[tobiasschweizer]

@mdelez I expanded the read-only check for XML values based on the mapping. However, this required a change in the value-type service's isReadOnly method. Is that ok? Since the service is provided in root, this is a breaking change.

done in 598abb5

[mdelez]

@mdelez I expanded the read-only check for XML values based on the mapping. However, this required a change in the value-type service's isReadOnly method. Is that ok? Since the service is provided in root, this is a breaking change.

done in 598abb5

Seems fine to me

[tobiasschweizer]

@mdelez awesome, I could add a new text!!!