CKEditor Backward Compatibility #224
Conversation
|
@loicjaouen Sorry, there was some merge accident. This PR replaces #212. |
sorry @tobiasschweizer , I didn't see your comment here but I answered it at length in DSP-788 |
I saw this (rather impressive testing) :-) So we can merge this PR but leave DSP-788 open? |
| @@ -6,6 +6,10 @@ | |||
| font-family: monospace; | |||
There was a problem hiding this comment.
@kilchenmann I have just notice that these styles are overridden by the app's main.scss:
* {
font-family: Arial, Helvetica, sans-serif;
}Any idea what could be done about that?
There was a problem hiding this comment.
Hm, we shouldn't use * { in this css. But it can happen in all apps.
There was a problem hiding this comment.
ng-deep is anyway deprecated since Angular v6. Could you add the two setups in ng-deep to the viewer.scss?
.ck-content code {
font-family: monospace !important;
}
.ck-content pre {
background-color: inherit !important;
}But not sure if this helps...
There was a problem hiding this comment.
@tobiasschweizer I just updated the code in the previous comment
|
@kilchenmann Mörci! |
resolves DSP-788
Reapplies changes from #212 which was merged by accident.