Minor fixes #143
Merged
Minor fixes #143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rename `helm-dash-available-docsets` because that name isn't appropiate at all. Docsets contributed by users are also "available", so what we want to differentiate is that there are official and unofficial (contributed by users) docsets.
Add docstring and remove unnecessary let wrapper.
It was doing the same as `helm-dash-read-json-from-url`, so we can call it directly from `helm-dash-official-docsets`.
…ocsets` Unify naming criteria with `helm-dash-official-docsets`. Would be nice if we could do the same with the output of the functions. One is returning a list and the other a list of lists.
This method isn't executing sql commands, it's returning a sql query to execute, so this is a proper name for it. Also, as helm-dash only gets content, it doesn't make sense to have "query-type" as an option, it's always "select". I update it also to don't crash if a invalid docset type is sent.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.