Move c:process_name/2 to the Broadway behaviour #285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seems like this callback was accidentally generated inside the module calling "use Broadway" instead of being part of the Broadway behaviour. This callback was originally introduced in #239.
whatyouhide
commented
Feb 8, 2022
| end | ||
|
|
||
| """ | ||
| @doc since: "1.1.0" |
There was a problem hiding this comment.
Had to put 1.1.0 here because it's never been available publicly before and I needed a minor version bump to introduce a new feature.
whatyouhide
commented
Feb 8, 2022
Comment on lines
+481
to
492
| defp default_process_name(broadway_name, base_name) when is_atom(broadway_name) do | ||
| :"#{broadway_name}.Broadway.#{base_name}" | ||
| end | ||
|
|
||
| defp default_process_name(broadway_name, _base_name) do | ||
| raise ArgumentError, """ | ||
| expected Broadway to be started with an atom :name, got: #{inspect(broadway_name)} | ||
|
|
||
| module.process_name(broadway_name, base_name) | ||
| If starting Broadway with a :name that is not an atom, you must define the \ | ||
| process_name/2 callback in the module which calls "use Broadway" (see the documentation). | ||
| """ | ||
| end |
There was a problem hiding this comment.
Moved the default implementation here, with the function_exported?/3 check.
josevalim
approved these changes
Feb 8, 2022
|
Could we get a release pushed to hex for this since it fixes a breaking change for those using the |
|
@kdawgwilk just released v1.0.3. 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems like this callback was accidentally generated inside the module calling
use Broadwayinstead of being part of the Broadway behaviour.This callback was originally introduced in #239.