Add timeout to request #125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
I don't know why it only fails on node 4. The error does not seem to exist in former builds: Also if you look at the coverage report, I actually increased the coverage on the files that I made changes. But somehow something and overall coverage rate has dropped. Maybe Coveralls' mechanism has changed. I would take care of these issues in other issues. |
dashersw
requested changes
Sep 30, 2018
Timeout in milliseconds could be provided in advertisement options of per Requester, or via COTE_REQUEST_TIMEOUT environment variable for all Requesters. Also request specific timeout option could be included in data section with property `__timeout`.
|
Thank you! ❤ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Timeout in milliseconds could be provided in advertisement options of per Requester, or via
COTE_REQUEST_TIMEOUTenvironment variable for all Requesters. Also request specific timeout option could be included in data section with property__timeout.Fixes #123