-
Notifications
You must be signed in to change notification settings - Fork 3
feat: implement fetchIdentityIdsByPublicKeys
method
#385
Conversation
* | ||
* @returns {Promise<Object>} | ||
*/ | ||
async fetchIdentityIdsByPublicKeys(publicKeyHashes) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe identityPublicKeyHashes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree. Something like fetchIdentityIdsByPublicKeyHashes
?
@@ -55,6 +55,18 @@ class CachedStateRepositoryDecorator { | |||
return this.stateRepository.fetchPublicKeyIdentityId(publicKeyHash); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we still need it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@shumkov I would like to leave it to keep tests working. After we merge it, we update tests, and then remove this method as a separate PR. This will save us some nerves.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Issue being fixed or feature implemented
As per new identity DIP we need a method to retrieve identity id by any public key hash
What was done?
Added
DriveStateRepository#fetchIdentityIdsByPublicKeys
methodHow Has This Been Tested?
Breaking Changes
None.
Checklist:
For repository code-owners and collaborators only