This repository has been archived by the owner on Dec 16, 2021. It is now read-only.
feat: implement fetchIdentityIdsByPublicKeys method
#385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shuplenkov
reviewed
Sep 10, 2020
| * | ||
| * @returns {Promise<Object>} | ||
| */ | ||
| async fetchIdentityIdsByPublicKeys(publicKeyHashes) { |
There was a problem hiding this comment.
maybe identityPublicKeyHashes?
There was a problem hiding this comment.
Agree. Something like fetchIdentityIdsByPublicKeyHashes?
shumkov
reviewed
Sep 10, 2020
| @@ -55,6 +55,18 @@ class CachedStateRepositoryDecorator { | |||
| return this.stateRepository.fetchPublicKeyIdentityId(publicKeyHash); | |||
There was a problem hiding this comment.
@shumkov I would like to leave it to keep tests working. After we merge it, we update tests, and then remove this method as a separate PR. This will save us some nerves.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
As per new identity DIP we need a method to retrieve identity id by any public key hash
What was done?
Added
DriveStateRepository#fetchIdentityIdsByPublicKeysmethodHow Has This Been Tested?
Breaking Changes
None.
Checklist:
For repository code-owners and collaborators only