feat(drive): create/update identities based on SML changes #170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shumkov
reviewed
Dec 30, 2021
shumkov
reviewed
Dec 30, 2021
packages/js-drive/lib/masternodes/manageMasternodesIdentities.js
Outdated
Show resolved
Hide resolved
added 2 commits
December 31, 2021 12:19
shumkov
reviewed
Dec 31, 2021
packages/js-drive/lib/abci/handlers/beginBlockHandlerFactory.js
Outdated
Show resolved
Hide resolved
shumkov
reviewed
Dec 31, 2021
shumkov
reviewed
Dec 31, 2021
packages/js-drive/lib/masternodes/manageMasternodesIdentities.js
Outdated
Show resolved
Hide resolved
shumkov
reviewed
Dec 31, 2021
packages/js-drive/lib/masternodes/manageMasternodesIdentities.js
Outdated
Show resolved
Hide resolved
shumkov
reviewed
Dec 31, 2021
packages/js-drive/lib/masternodes/manageMasternodesIdentities.js
Outdated
Show resolved
Hide resolved
shumkov
reviewed
Dec 31, 2021
packages/js-drive/lib/masternodes/manageMasternodesIdentities.js
Outdated
Show resolved
Hide resolved
shumkov
reviewed
Dec 31, 2021
packages/js-drive/lib/masternodes/manageMasternodesIdentities.js
Outdated
Show resolved
Hide resolved
shumkov
reviewed
Dec 31, 2021
packages/js-drive/lib/masternodes/manageMasternodesIdentities.js
Outdated
Show resolved
Hide resolved
shumkov
reviewed
Dec 31, 2021
packages/js-drive/lib/masternodes/manageMasternodesIdentities.js
Outdated
Show resolved
Hide resolved
shumkov
reviewed
Dec 31, 2021
packages/js-drive/lib/masternodes/manageMasternodesIdentities.js
Outdated
Show resolved
Hide resolved
shumkov
reviewed
Dec 31, 2021
packages/js-drive/lib/masternodes/manageMasternodesIdentities.js
Outdated
Show resolved
Hide resolved
shumkov
reviewed
Dec 31, 2021
packages/js-drive/lib/masternodes/manageMasternodesIdentities.js
Outdated
Show resolved
Hide resolved
|
This pull request introduces 3 alerts when merging 985a435 into 31d97af - view on LGTM.com new alerts:
|
added 6 commits
January 10, 2022 14:39
# Conflicts: # packages/js-drive/lib/createDIContainer.js # packages/js-drive/test/unit/abci/handlers/initChainHandlerFactory.spec.js
shumkov
requested changes
Jan 19, 2022
packages/js-drive/lib/identity/masternode/handleUpdatedPubKeyOperatorFactory.js
Show resolved
Hide resolved
packages/js-drive/lib/identity/masternode/handleNewMasternodeFactory.js
Outdated
Show resolved
Hide resolved
packages/js-drive/lib/identity/masternode/handleUpdatedPubKeyOperatorFactory.js
Outdated
Show resolved
Hide resolved
packages/js-drive/lib/identity/masternode/handleUpdatedPubKeyOperatorFactory.js
Outdated
Show resolved
Hide resolved
packages/js-drive/lib/identity/masternode/synchronizeMasternodeIdentitiesFactory.js
Show resolved
Hide resolved
packages/js-drive/lib/identity/masternode/synchronizeMasternodeIdentitiesFactory.js
Outdated
Show resolved
Hide resolved
packages/js-drive/lib/identity/masternode/synchronizeMasternodeIdentitiesFactory.js
Show resolved
Hide resolved
packages/js-drive/lib/identity/masternode/synchronizeMasternodeIdentitiesFactory.js
Outdated
Show resolved
Hide resolved
packages/js-drive/lib/identity/masternode/synchronizeMasternodeIdentitiesFactory.js
Show resolved
Hide resolved
…eIdentitiesFactory.js Co-authored-by: Ivan Shumkov <ivan@shumkov.ru>
|
This pull request introduces 1 alert when merging 44bb798 into ec8454f - view on LGTM.com new alerts:
|
shumkov
reviewed
Jan 25, 2022
packages/js-drive/lib/identity/masternode/synchronizeMasternodeIdentitiesFactory.js
Show resolved
Hide resolved
shumkov
requested changes
Jan 27, 2022
packages/js-dpp/lib/identity/validation/validatePublicKeysFactory.js
Outdated
Show resolved
Hide resolved
packages/platform-test-suite/test/functional/platform/Identity.spec.js
Outdated
Show resolved
Hide resolved
shumkov
reviewed
Jan 27, 2022
packages/js-dpp/lib/identity/validation/validatePublicKeysFactory.js
Outdated
Show resolved
Hide resolved
shumkov
approved these changes
Jan 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
Need to create/update identities based on SML changes without removing identities and charging fees and without creation of withdrawal public key
What was done?
Implemented create/update identities based on SML changes in drive
How Has This Been Tested?
With tests
Breaking Changes
No
Checklist:
For repository code-owners and collaborators only