fix(drive)!: non-deterministic behaviour in masternode identities logic #287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e-identities' into fix-non-determinism-in-masternode-identities
|
This pull request introduces 1 alert when merging 51e6f7d into d920064 - view on LGTM.com new alerts:
|
|
This pull request introduces 1 alert when merging 3e21553 into d920064 - view on LGTM.com new alerts:
|
…e-identities' into fix-non-determinism-in-masternode-identities # Conflicts: # packages/js-drive/test/integration/identity/masternode/synchronizeMasternodeIdentitiesFactory.spec.js
….com:dashevo/platform into fix-non-determinism-in-masternode-identities
…e-identities' into fix-non-determinism-in-masternode-identities # Conflicts: # packages/js-drive/test/integration/identity/masternode/synchronizeMasternodeIdentitiesFactory.spec.js
….com:dashevo/platform into fix-non-determinism-in-masternode-identities
…e-identities' into fix-non-determinism-in-masternode-identities
…e-identities' into fix-non-determinism-in-masternode-identities
….com:dashevo/platform into fix-non-determinism-in-masternode-identities
….com:dashevo/platform into fix-non-determinism-in-masternode-identities
jawid-h
changed the title
…e-identities' into fix-non-determinism-in-masternode-identities
shumkov
changed the title
shumkov
changed the title
shumkov
changed the title
QuantumExplorer
approved these changes
Mar 10, 2022
| try { | ||
| ({ result: rawTransaction } = await coreRpcClient.getRawTransaction(id, 1)); | ||
| } catch (e) { | ||
| // Invalid address or key error |
There was a problem hiding this comment.
I think if it times out you should retry. Not essential for this version but still something todo.
There was a problem hiding this comment.
That's a good idea. We have something about connection reliability with Core in our backlog.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
The creation of masternode reward share documents is not deterministic which leads to a chain halt.
There is a lack of tests so many issues were visible on only testnet.
What was done?
operatorRewardin a local network (dashmate)$ownerIdandpayToIdpairawaitHow Has This Been Tested?
With integration test
Breaking Changes
The fixed masternode identities logic breaks compatibility with previous invalid state.
Checklist:
For repository code-owners and collaborators only