-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(sdk): incomplete bundle for web #400
Conversation
…k webpack config in platform-test-suite/karma.conf.js
This reverts commit 44e231f.
This pull request introduces 1 alert when merging c8c6225 into 328554f - view on LGTM.com new alerts:
|
This pull request introduces 1 alert when merging 195f015 into 328554f - view on LGTM.com new alerts:
|
This pull request introduces 1 alert when merging 2e4e203 into 66bfd20 - view on LGTM.com new alerts:
|
This pull request introduces 1 alert when merging 9f7f1e6 into 66bfd20 - view on LGTM.com new alerts:
|
This pull request introduces 1 alert when merging bb5fe18 into 66bfd20 - view on LGTM.com new alerts:
|
This pull request introduces 1 alert when merging 9f8d3f7 into 66bfd20 - view on LGTM.com new alerts:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work
packages/platform-test-suite/test/functional/core/getTransaction.spec.js
Outdated
Show resolved
Hide resolved
packages/platform-test-suite/test/functional/platform/Identity.spec.js
Outdated
Show resolved
Hide resolved
This pull request introduces 1 alert when merging 92c32c2 into 66bfd20 - view on LGTM.com new alerts:
|
This pull request introduces 1 alert when merging 1a12098 into 66bfd20 - view on LGTM.com new alerts:
|
This pull request introduces 1 alert when merging ef4d5be into 66bfd20 - view on LGTM.com new alerts:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job! 👍
Issue being fixed or feature implemented
The fix enables zero-config SDK builds for browser-based apps. This change is needed because configuring webpack at the end-user side became non-trivial, and for certain environments (such as Create React App) it's not possible without ejecting/rewiring configuration which leads to poor developer experience and makes CRA upgrades more complicated.
Issues considered relevant
yarn build:web
can't find packagews
#403in
operator throwsIdentifier expects Buffer
#234What was done?
Reworked SDK
build
commandIntroduced
browser
entry intopackage.json
to use minified webpack bundle instead of a TS buildThis change makes platform-test-suite to use SDK
umd
build in karma instead of bundling a TS build, hence providing equal to WebApp conditionsExposed DPP primitives and Node.JS essentials via SDK API
Refactored platform-test-suite to use bundled primitives and essential Platform functions exposed from the
dash
packageUpdated relevant tutorials in dashplatform.readme.io to use
Buffer
from thedash
package instead ofBuffer
from theglobal
scopeHow Has This Been Tested?
dash
in Create React AppBreaking Changes
Checklist:
For repository code-owners and collaborators only