Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Drive and DAPI expect data available on H+1 block #497

Merged
merged 6 commits into from
Aug 22, 2022

Conversation

shumkov
Copy link
Member

@shumkov shumkov commented Aug 19, 2022

Issue being fixed or feature implemented

After #484, waitForStateTransitionResult do not need to wait for next block to obtain block signature anymore. Also, Drive should respond with current block data.

What was done?

  • Remove the waiting for next block logic
  • Updated Drive's endpoint to respond with current block data

How Has This Been Tested?

Tests

Breaking Changes

None

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@shumkov shumkov added this to the v0.23.0 milestone Aug 19, 2022
@shumkov shumkov requested a review from antouhou as a code owner August 19, 2022 11:39
@lgtm-com
Copy link

lgtm-com bot commented Aug 19, 2022

This pull request introduces 1 alert when merging dd73721 into 085446f - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

shuplenkov
shuplenkov previously approved these changes Aug 19, 2022
@shumkov shumkov changed the title fix(dapi): waitForStateTransitionResult still wait for next block fix: waitForStateTransitionResult still wait for next block Aug 19, 2022
@shumkov shumkov changed the title fix: waitForStateTransitionResult still wait for next block fix: Drive and DAPI expect data available on H+1 block Aug 19, 2022
@shumkov shumkov merged commit 1db8565 into v0.23-dev Aug 22, 2022
@shumkov shumkov deleted the do-not-wait-for-next-block branch August 22, 2022 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants