Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dpp): add wasm-dpp template package #529

Merged
merged 3 commits into from
Sep 22, 2022
Merged

feat(dpp): add wasm-dpp template package #529

merged 3 commits into from
Sep 22, 2022

Conversation

antouhou
Copy link
Collaborator

This PR adds a template for the wasm-dpp binding, so we can better track changes to the tests and the interface better in the future when the actual work is going to be done.

Issue being fixed or feature implemented

Copied package and tests from js-dpp into a new wasm-dpp package, removing lib directory that is going to be replaced with the wasm-dpp source files

What was done?

Created new wasm-dpp package, added it to the workspaces, and copied the necessary files from the js-dpp package

How Has This Been Tested?

Doesn't require testing just yet

Breaking Changes

None just yet

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

feat: add wasm-dpp template package
@antouhou antouhou changed the base branch from v0.23-dev to v0.24-dev September 22, 2022 09:15
@lgtm-com
Copy link

lgtm-com bot commented Sep 22, 2022

This pull request introduces 1 alert when merging 2f42bec into 36e6c1c - view on LGTM.com

new alerts:

  • 1 for Disabling certificate validation

Copy link
Member

@shumkov shumkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@shumkov shumkov merged commit e63d9ba into v0.24-dev Sep 22, 2022
@shumkov shumkov deleted the feat-dpp-wasm branch September 22, 2022 11:45
@shumkov shumkov changed the title feat: add wasm-dpp template package feat(dpp): add wasm-dpp template package Sep 22, 2022
@thephez thephez added this to the v0.24.0 milestone Sep 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants