Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(sdk): platform.initialize is not a function #555

Merged
merged 2 commits into from
Oct 4, 2022
Merged

fix(sdk): platform.initialize is not a function #555

merged 2 commits into from
Oct 4, 2022

Conversation

markin-io
Copy link
Contributor

Issue being fixed or feature implemented

PR fixes a bug with the call of waitForCoreChainLockedHeight with a wrong platform argument

What was done?

How Has This Been Tested?

Breaking Changes

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@markin-io markin-io added this to the v0.23.0 milestone Oct 4, 2022
@lgtm-com
Copy link

lgtm-com bot commented Oct 4, 2022

This pull request fixes 1 alert when merging 56a97e2 into 1960a1e - view on LGTM.com

fixed alerts:

  • 1 for Superfluous trailing arguments

shumkov
shumkov previously approved these changes Oct 4, 2022
View reviewed changes
Copy link
Member

@shumkov shumkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@lgtm-com
Copy link

lgtm-com bot commented Oct 4, 2022

This pull request fixes 1 alert when merging 37bd7ee into 1960a1e - view on LGTM.com

fixed alerts:

  • 1 for Superfluous trailing arguments

@shumkov shumkov merged commit dd600c3 into master Oct 4, 2022
@shumkov shumkov deleted the fix/platform-initialize-is-not-a-function branch October 4, 2022 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shumkov shumkov shumkov left review comments

@antouhou antouhou Awaiting requested review from antouhou

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.23.0
Development

Successfully merging this pull request may close these issues.
2 participants
@markin-io @shumkov