This repository was archived by the owner on Apr 13, 2025. It is now read-only.
Dirty tracking #65
Merged
Dirty tracking #65
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Goal is to only send changed fields when saving. * Had to change the API for adding a new label to a story since coercion and dirty tracking are done via the attribute writer. * Added test to verify that only changes attributes are sent on save.
* Bump major version number to signal backwards incompatible API change and start clean with semantic versioning.
|
@forest this is awesome! Thanks so much! |
…ction type. * Just provides a warning to users that Array#<< subverts coercion and dirty tracking.
|
Awesome job, @forest! Thanks for working so hard on this! |
|
I tested your branch on my project (with a very simple test) and it worked as expected. |
|
Great. Thanks for the feedback and reviewing the changes. I'll get this released. My goal is to put some of the foundational things in place and keep the code easy to understand so many people can contribute. The majority of my use cases are reading data, so I'm happy to have the help on update features. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #62 while keeping the
Story#saveinterface.