This repository was archived by the owner on Apr 13, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 105
Add story transitions #87
Closed
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
forest
suggested changes
Jan 2, 2017
lib/tracker_api/resources/story.rb
Outdated
# | ||
# @param [Hash] params | ||
# @return [Array[StoryTransition]] | ||
def story_transitions(params = {}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be named transitions
so that it is an override of the getter. The getter is implementing a lazy load of the transitions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool. So the test .json is now generated. But the story that's used doesn't have any transitions:
request:
"request":{
"method":"get",
"uri":"https://www.pivotaltracker.com/services/v5/projects/1027488/stories/66728004/transitions",
...
response:
"response":{
"status":{
"code":200,
"message":null
},
...
Do I need to add a transition to that story, or should I rely on a another story which has transitions?
I'll figure out the tests. Thanks for contributing. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will add story transitions end point. Finishes #86
I'm not certain how to get VCR to generate the right .json.