add story#add_owner method using owner's API

[drselump14]

somehow I couldn't add owner using self.owners= method, so I add add_owner method using owner's API

• add attribute person for Comment model, because it's needed to get person object directly from comment

[coveralls]

Coverage decreased (-0.4%) to 95.991% when pulling 01ccd12 on drselump14:master into d0b5962 on dashofcode:master.

[forest]

@drselump14 you can add to the array of owner_ids and that will get save with the story is saved. See https://github.com/dashofcode/tracker_api/pull/88/files#diff-7801f5012a085139832e168522bc85dcL55.

You should need to add the new endpoint.

If you want the story.owners= to work you can override and update the owner_ids. Make sure you have the current list of owners or owner_ids so you don't overwrite existing owners.

[drselump14]

@forest Thanks for the reply.
I've tried the owner_ids= method before, but sometimes it didn't work as expected. I don't know how to replicate the bug. Maybe that's the reason why they provide API for posting owners.

'You should need to add the new endpoint.'
Could you please explain more about this point please? I think story_owners endpoint is fit with this function.

[forest]

I'll take a look. If there is a bug with owner_ids it would be good to fix that. Having multiple ways to do the same this isn't ideal unless there is good reason. Your solution might be the right one.

…

On Mon, Jan 2, 2017 at 6:56 PM Kris ***@***.***> wrote: @forest <https://github.com/forest> Thanks for the reply. I've tried the owner_ids= method before, but sometimes it didn't work as expected. I don't know how to replicate the bug. Maybe that's the reason why they provide API for posting owners. 'You should need to add the new endpoint.' Could you please explain more about this point please? I think story_owners endpoint is fit with this function. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#88 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAAelQ-ClpnQfmLTdV_gmDQ4pQAHODekks5rObjKgaJpZM4LYlBW> .

[drselump14]

You're right , i agree with you.

…

On 01/02 07:29:26 PM, Forest wrote: I'll take a look. If there is a bug with owner_ids it would be good to fix that. Having multiple ways to do the same this isn't ideal unless there is good reason. Your solution might be the right one. On Mon, Jan 2, 2017 at 6:56 PM Kris ***@***.***> wrote: > @forest <https://github.com/forest> Thanks for the reply. > I've tried the owner_ids= method before, but sometimes it didn't work as > expected. I don't know how to replicate the bug. Maybe that's the reason > why they provide API for posting owners. > > 'You should need to add the new endpoint.' > Could you please explain more about this point please? I think > story_owners endpoint is fit with this function. > > — > You are receiving this because you were mentioned. > > > Reply to this email directly, view it on GitHub > <#88 (comment)>, > or mute the thread > <https://github.com/notifications/unsubscribe-auth/AAAelQ-ClpnQfmLTdV_gmDQ4pQAHODekks5rObjKgaJpZM4LYlBW> > . > -- You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub: #88 (comment)

[coveralls]

Coverage decreased (-0.4%) to 96.009% when pulling 04c32a6 on drselump14:master into ac3be0a on dashofcode:master.

[forest]

This is not needed. Just use owner_ids=.

story.owner_ids = [123, 456]