fix: possible assert call if nHeight in CDeterministicMNList is higher then Tip #5590

knst · 2023-09-28T18:15:29Z

Issue being fixed or feature implemented

fix: possible assert call if nHeight in CDeterministicMNListDiff is higher than Tip

Example of new log:

2023-09-28T17:35:50Z GetProjectedMNPayeesAtChainTip WARNING pindex is nullptr due to height=914160 chain height=914159

instead assert call:

...
     #6  0x00007ffff7a33b86 in __assert_fail (assertion=0x55555783afd2 "pindex", file=0x5555577f2ed8 "llmq/utils.cpp", line=730,
            function=0x5555577f2448 "bool llmq::utils::IsMNRewardReallocationActive(const CBlockIndex*)") at ./assert/assert.c:101
     #7  0x0000555555ab7daf in llmq::utils::IsMNRewardReallocationActive (pindex=<optimized out>) at llmq/utils.cpp:730
     #8  0x00005555559458ad in CDeterministicMNList::GetProjectedMNPayees (this=this@entry=0x7fffffffc690, pindex=0x0, nCount=<optimized out>, nCount@entry=2147483647)
            at evo/deterministicmns.cpp:231
     #9  0x000055555594614f in CDeterministicMNList::GetProjectedMNPayeesAtChainTip (this=this@entry=0x7fffffffc690, nCount=nCount@entry=2147483647) at evo/deterministicmns.cpp:216
     #10 0x00005555558c9f51 in MasternodeList::updateDIP3List (this=this@entry=0x55555908cfd0) at qt/masternodelist.cpp:194
     #11 0x00005555558ca9a0 in MasternodeList::updateDIP3ListScheduled (this=0x55555908cfd0) at qt/masternodelist.cpp:157
     #12 0x000055555684a60f in void doActivate<false>(QObject*, int, void**) ()
     #13 0x00005555568525b1 in QTimer::timerEvent(QTimerEvent*) ()
     #14 0x0000555556844ce5 in QObject::event(QEvent*) ()
     #15 0x0000555556ac3252 in QApplicationPrivate::notify_helper(QObject*, QEvent*) ()
     #16 0x000055555681e6b8 in QCoreApplication::sendEvent(QObject*, QEvent*) ()
     #17 0x000055555686de2a in QTimerInfoList::activateTimers() ()
     #18 0x000055555686be84 in QEventDispatcherUNIX::processEvents(QFlags<QEventLoop::ProcessEventsFlag>) ()
     #19 0x00005555569bf8a2 in QXcbUnixEventDispatcher::processEvents(QFlags<QEventLoop::ProcessEventsFlag>) ()
     #20 0x000055555681caf6 in QEventLoop::exec(QFlags<QEventLoop::ProcessEventsFlag>) ()
     #21 0x0000555556825f8a in QCoreApplication::exec() ()
...

What was done?

ClientModel returns now a pair: MNList and CBlockIndex; so, we always know the which one has been used even if current chain is switched.

How Has This Been Tested?

Run on my localhost from c034ff0c2606142ba3e8894bc74f693b87374e5c - aborted with backtrace like above.
With both of commit - no assert more.

Breaking Changes

N/A

Checklist:

I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I have added or updated relevant unit/integration/functional/e2e tests
I have made corresponding changes to the documentation
I have assigned this pull request to a milestone

knst · 2023-09-28T18:20:07Z

~~@UdjinM6 @PastaPastaPasta please, suggest me which of 2 solution [see 2 commits in PR] to apply. I don't like both of them but any of them is better then current develop over 9000 percents.~~

~~Or any alternate better solution?~~

UPD: done

ogabrielides

I vote for 04fc666.
Feels more right to me.

PastaPastaPasta · 2023-09-29T13:17:22Z

What if we adjust the calling locations to ensure they're not null there?

knst · 2023-09-29T13:33:46Z

What if we adjust the calling locations to ensure they're not null there?

It can be wrong chain (wrong fork) anyway

UdjinM6

utACK

ogabrielides

ACK

PastaPastaPasta · 2023-10-03T15:18:11Z

I think concept NACK, but not positive;

This function is called from these locations, the problematic call is the qt/masternodelist.cpp location;

src/governance/governance.cpp:679:        auto mn_payees = mnList.GetProjectedMNPayeesAtChainTip();
src/qt/masternodelist.cpp:194:    auto projectedPayees = mnList.GetProjectedMNPayeesAtChainTip();
src/rpc/masternode.cpp:139:    auto payees = mnList.GetProjectedMNPayeesAtChainTip(heightShift);

I believe that this issue is only possible when the mnList is stale; I think there is a root problem here that cached qt mnListCached is not properly updated when the block was rejected/marked as conflicted/undone. see src/qt/clientmodel.h:121. I'm not STRICTLY opposed to the fix as done here, but I would like to see the underlying issue fixed or investigated more.

…igher than Tip Example of new log: ``` 2023-09-28T17:35:50Z GetProjectedMNPayeesAtChainTip WARNING pindex is nullptr due to height=914160 chain height=914159 ``` instead assert call: ``` ... dashpay#6 0x00007ffff7a33b86 in __assert_fail (assertion=0x55555783afd2 "pindex", file=0x5555577f2ed8 "llmq/utils.cpp", line=730, function=0x5555577f2448 "bool llmq::utils::IsMNRewardReallocationActive(const CBlockIndex*)") at ./assert/assert.c:101 dashpay#7 0x0000555555ab7daf in llmq::utils::IsMNRewardReallocationActive (pindex=<optimized out>) at llmq/utils.cpp:730 dashpay#8 0x00005555559458ad in CDeterministicMNList::GetProjectedMNPayees (this=this@entry=0x7fffffffc690, pindex=0x0, nCount=<optimized out>, nCount@entry=2147483647) at evo/deterministicmns.cpp:231 dashpay#9 0x000055555594614f in CDeterministicMNList::GetProjectedMNPayeesAtChainTip (this=this@entry=0x7fffffffc690, nCount=nCount@entry=2147483647) at evo/deterministicmns.cpp:216 dashpay#10 0x00005555558c9f51 in MasternodeList::updateDIP3List (this=this@entry=0x55555908cfd0) at qt/masternodelist.cpp:194 dashpay#11 0x00005555558ca9a0 in MasternodeList::updateDIP3ListScheduled (this=0x55555908cfd0) at qt/masternodelist.cpp:157 dashpay#12 0x000055555684a60f in void doActivate<false>(QObject*, int, void**) () dashpay#13 0x00005555568525b1 in QTimer::timerEvent(QTimerEvent*) () dashpay#14 0x0000555556844ce5 in QObject::event(QEvent*) () dashpay#15 0x0000555556ac3252 in QApplicationPrivate::notify_helper(QObject*, QEvent*) () dashpay#16 0x000055555681e6b8 in QCoreApplication::sendEvent(QObject*, QEvent*) () dashpay#17 0x000055555686de2a in QTimerInfoList::activateTimers() () dashpay#18 0x000055555686be84 in QEventDispatcherUNIX::processEvents(QFlags<QEventLoop::ProcessEventsFlag>) () dashpay#19 0x00005555569bf8a2 in QXcbUnixEventDispatcher::processEvents(QFlags<QEventLoop::ProcessEventsFlag>) () dashpay#20 0x000055555681caf6 in QEventLoop::exec(QFlags<QEventLoop::ProcessEventsFlag>) () dashpay#21 0x0000555556825f8a in QCoreApplication::exec() () ... ```

…even wrong tip)

…eDIP3List()`

…ount, should reserve memory accordingly

knst · 2023-10-26T13:55:23Z

the problematic call is the qt/masternodelist.cpp location

The problematic call is indeed qt/masternodelist.cpp location because mnList is saved once and later used (can be much later than it is init).
Other places use mnList right after initialization so chain doesn't have chance to switch usually so it has not been reproduced by non-GUI code yet but also can happen.

latest commits fix all usages of GetProjectedMNPayeesAtChainTip

UdjinM6 · 2023-10-26T14:08:55Z

fails to compile for me

qt/masternodelist.cpp:232:61: error: reference to local binding 'mnList' declared in enclosing function 'MasternodeList::updateDIP3List'

d109650 helps

UdjinM6

Tested and it looks good 👍 (reindexed and invalidated/reconsidered ~100 blocks from the tip).

ACK

PastaPastaPasta

utACK for squash merge

…igher than Tip - cummulative from dashpay#5590 Example of new log: ``` 2023-09-28T17:35:50Z GetProjectedMNPayeesAtChainTip WARNING pindex is nullptr due to height=914160 chain height=914159 ``` instead assert call: ``` ... dashpay#6 0x00007ffff7a33b86 in __assert_fail (assertion=0x55555783afd2 "pindex", file=0x5555577f2ed8 "llmq/utils.cpp", line=730, function=0x5555577f2448 "bool llmq::utils::IsMNRewardReallocationActive(const CBlockIndex*)") at ./assert/assert.c:101 dashpay#7 0x0000555555ab7daf in llmq::utils::IsMNRewardReallocationActive (pindex=<optimized out>) at llmq/utils.cpp:730 dashpay#8 0x00005555559458ad in CDeterministicMNList::GetProjectedMNPayees (this=this@entry=0x7fffffffc690, pindex=0x0, nCount=<optimized out>, nCount@entry=2147483647) at evo/deterministicmns.cpp:231 dashpay#9 0x000055555594614f in CDeterministicMNList::GetProjectedMNPayeesAtChainTip (this=this@entry=0x7fffffffc690, nCount=nCount@entry=2147483647) at evo/deterministicmns.cpp:216 dashpay#10 0x00005555558c9f51 in MasternodeList::updateDIP3List (this=this@entry=0x55555908cfd0) at qt/masternodelist.cpp:194 dashpay#11 0x00005555558ca9a0 in MasternodeList::updateDIP3ListScheduled (this=0x55555908cfd0) at qt/masternodelist.cpp:157 dashpay#12 0x000055555684a60f in void doActivate<false>(QObject*, int, void**) () dashpay#13 0x00005555568525b1 in QTimer::timerEvent(QTimerEvent*) () dashpay#14 0x0000555556844ce5 in QObject::event(QEvent*) () dashpay#15 0x0000555556ac3252 in QApplicationPrivate::notify_helper(QObject*, QEvent*) () dashpay#16 0x000055555681e6b8 in QCoreApplication::sendEvent(QObject*, QEvent*) () dashpay#17 0x000055555686de2a in QTimerInfoList::activateTimers() () dashpay#18 0x000055555686be84 in QEventDispatcherUNIX::processEvents(QFlags<QEventLoop::ProcessEventsFlag>) () dashpay#19 0x00005555569bf8a2 in QXcbUnixEventDispatcher::processEvents(QFlags<QEventLoop::ProcessEventsFlag>) () dashpay#20 0x000055555681caf6 in QEventLoop::exec(QFlags<QEventLoop::ProcessEventsFlag>) () dashpay#21 0x0000555556825f8a in QCoreApplication::exec() () ... ``` fix: use g_chainman.m_blockman.LookupBlockIndex for any known block (even wrong tip) fix: handle GetProjectedMNPayees's failures in `MasternodeList::updateDIP3List()` fix: resulting vector in GetProjectedMNPayees grows to the weighted count, should reserve memory accordingly fix: avoid useless loop in GetProjectedMNPayees after mn_rr activation fix: pass proper CBlockIndex from ClientModel fix statusItem

knst added this to the 20 milestone Sep 28, 2023

knst requested review from PastaPastaPasta and UdjinM6 September 28, 2023 18:15

knst changed the title ~~fix: possible assert call if nHeight in CDeterministicMNListDiff is higher than Tip~~ fix: possible assert call if nHeight in CDeterministicMNList is higher than Tip Sep 28, 2023

knst changed the title ~~fix: possible assert call if nHeight in CDeterministicMNList is higher than Tip~~ fix: possible assert call if nHeight in CDeterministicMNList is higher then Tip Sep 28, 2023

ogabrielides reviewed Sep 28, 2023

View reviewed changes

UdjinM6 previously approved these changes Oct 3, 2023

View reviewed changes

ogabrielides previously approved these changes Oct 3, 2023

View reviewed changes

UdjinM6 mentioned this pull request Oct 21, 2023

fix: Various fixes for GetProjectedMNPayees #5638

Closed

5 tasks

knst modified the milestones: 20, 21 Oct 23, 2023

knst and others added 6 commits October 26, 2023 20:32

fix: use g_chainman.m_blockman.LookupBlockIndex for any known block (…

ca61600

…even wrong tip)

fix: handle GetProjectedMNPayees's failures in `MasternodeList::updat…

8e63c16

…eDIP3List()`

fix: resulting vector in GetProjectedMNPayees grows to the weighted c…

2ca24de

…ount, should reserve memory accordingly

fix: avoid useless loop in GetProjectedMNPayees after mn_rr activation

660a5ca

fix: pass proper CBlockIndex from ClientModel

e258c36

knst dismissed stale reviews from ogabrielides and UdjinM6 via e258c36 October 26, 2023 13:43

knst force-pushed the fix-possible-crash-deterministic branch from 04fc666 to e258c36 Compare October 26, 2023 13:43

knst requested a review from UdjinM6 October 26, 2023 13:46

UdjinM6 modified the milestones: 21, 20 Oct 26, 2023

fix statusItem

41560f0

UdjinM6 approved these changes Oct 26, 2023

View reviewed changes

knst mentioned this pull request Oct 27, 2023

refactor: use more gsl::not_null in utils.h and deterministicmns.h #5651

Merged

5 tasks

PastaPastaPasta approved these changes Oct 28, 2023

View reviewed changes

PastaPastaPasta merged commit a0c8c9f into dashpay:develop Oct 28, 2023
6 of 8 checks passed

knst mentioned this pull request Nov 6, 2023

fix: actually vote NO on triggers we don't like, some additional cleanups and tests #5670

Merged

5 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: possible assert call if nHeight in CDeterministicMNList is higher then Tip #5590

fix: possible assert call if nHeight in CDeterministicMNList is higher then Tip #5590

knst commented Sep 28, 2023 •

edited

Loading

knst commented Sep 28, 2023 •

edited

Loading

ogabrielides left a comment

PastaPastaPasta commented Sep 29, 2023

knst commented Sep 29, 2023

UdjinM6 left a comment

ogabrielides left a comment

PastaPastaPasta commented Oct 3, 2023

knst commented Oct 26, 2023

UdjinM6 commented Oct 26, 2023

UdjinM6 left a comment

PastaPastaPasta left a comment

fix: possible assert call if nHeight in CDeterministicMNList is higher then Tip #5590

fix: possible assert call if nHeight in CDeterministicMNList is higher then Tip #5590

Conversation

knst commented Sep 28, 2023 • edited Loading

Issue being fixed or feature implemented

What was done?

How Has This Been Tested?

Breaking Changes

Checklist:

knst commented Sep 28, 2023 • edited Loading

ogabrielides left a comment

Choose a reason for hiding this comment

PastaPastaPasta commented Sep 29, 2023

knst commented Sep 29, 2023

UdjinM6 left a comment

Choose a reason for hiding this comment

ogabrielides left a comment

Choose a reason for hiding this comment

PastaPastaPasta commented Oct 3, 2023

knst commented Oct 26, 2023

UdjinM6 commented Oct 26, 2023

UdjinM6 left a comment

Choose a reason for hiding this comment

PastaPastaPasta left a comment

Choose a reason for hiding this comment

knst commented Sep 28, 2023 •

edited

Loading

knst commented Sep 28, 2023 •

edited

Loading