Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update ProviderUpdateServiceTx to fully support BASIC_BLS_VERSION #215

Merged
merged 2 commits into from
Jun 6, 2023

Conversation

HashEngineering
Copy link
Collaborator

Issue being fixed or feature implemented

What was done?

Add the rest serialization support for version 2 of the ProviderUpdateServiceTx payload.

How Has This Been Tested?

Breaking Changes

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@HashEngineering HashEngineering self-assigned this Jun 1, 2023
@codecov
Copy link

codecov bot commented Jun 1, 2023

Codecov Report

Patch coverage: 44.44% and project coverage change: +0.06 🎉

Comparison is base (cee53a1) 46.79% compared to head (67f54e6) 46.86%.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #215      +/-   ##
============================================
+ Coverage     46.79%   46.86%   +0.06%     
- Complexity     6383     6396      +13     
============================================
  Files           408      408              
  Lines         45868    45885      +17     
  Branches       6487     6492       +5     
============================================
+ Hits          21466    21502      +36     
+ Misses        22006    21985      -21     
- Partials       2396     2398       +2     
Impacted Files Coverage Δ
...rg/bitcoinj/evolution/ProviderUpdateServiceTx.java 52.63% <44.44%> (+3.91%) ⬆️

... and 12 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@Syn-McJ Syn-McJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@HashEngineering HashEngineering merged commit 0072075 into master Jun 6, 2023
@HashEngineering HashEngineering deleted the bugfix-proupservtx branch July 3, 2023 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants