Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't watch disconnects if dropping peers after broadcast #229

Merged
merged 1 commit into from
Sep 7, 2023

Conversation

HashEngineering
Copy link
Collaborator

Issue being fixed or feature implemented

If we are dropping peers after sending, then don't watch disconnects to detect errors in transactions.

What was done?

How Has This Been Tested?

Breaking Changes

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

Signed-off-by: HashEngineering <hashengineeringsolutions@gmail.com>
@HashEngineering HashEngineering self-assigned this Sep 5, 2023
@HashEngineering HashEngineering marked this pull request as ready for review September 5, 2023 18:09
@codecov
Copy link

codecov bot commented Sep 5, 2023

Codecov Report

Patch coverage: 33.33% and project coverage change: -0.02% ⚠️

Comparison is base (6422489) 47.08% compared to head (95bf5f8) 47.07%.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #229      +/-   ##
============================================
- Coverage     47.08%   47.07%   -0.02%     
+ Complexity     6467     6462       -5     
============================================
  Files           408      408              
  Lines         45878    45879       +1     
  Branches       6481     6481              
============================================
- Hits          21603    21597       -6     
- Misses        21900    21902       +2     
- Partials       2375     2380       +5     
Files Changed Coverage Δ
...n/java/org/bitcoinj/core/TransactionBroadcast.java 10.48% <33.33%> (-0.09%) ⬇️

... and 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@HashEngineering HashEngineering merged commit 63c08c8 into master Sep 7, 2023
5 of 7 checks passed
@Syn-McJ Syn-McJ deleted the bugfix-send-disconnect-listener branch September 7, 2023 03:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants