Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use Comparator that can handle long when sorting transactions #241

Merged
merged 2 commits into from
Dec 23, 2023

Conversation

HashEngineering
Copy link
Collaborator

  • separate reset and rescan functions

Issue being fixed or feature implemented

This should be resolved by not casting long time differences to int.

10:52:53 [main] CrashReporter - crashing because of uncaught exception
java.lang.IllegalArgumentException: Comparison method violates its general contract!
	at java.util.TimSort.mergeLo(TimSort.java:781) ~[na:0.0]
	at java.util.TimSort.mergeAt(TimSort.java:518) ~[na:0.0]
	at java.util.TimSort.mergeCollapse(TimSort.java:448) ~[na:0.0]
	at java.util.TimSort.sort(TimSort.java:245) ~[na:0.0]
	at java.util.Arrays.sort(Arrays.java:1263) ~[na:0.0]
	at j$.util.List$-EL.sort(SourceFile:0) ~[na:0.0]
	at org.bitcoinj.wallet.authentication.AuthenticationGroupExtension.reset(AuthenticationGroupExtension.java:893) ~[na:0.0]

What was done?

How Has This Been Tested?

Breaking Changes

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

* separate reset and rescan functions

Signed-off-by: HashEngineering <hashengineeringsolutions@gmail.com>
Copy link
Member

@Syn-McJ Syn-McJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

…stead of reset

Signed-off-by: HashEngineering <hashengineeringsolutions@gmail.com>
Copy link

codecov bot commented Dec 23, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (ef7d3cc) 48.02% compared to head (6ff1a4d) 48.02%.

Files Patch % Lines
...t/authentication/AuthenticationGroupExtension.java 85.71% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##             master     #241   +/-   ##
=========================================
  Coverage     48.02%   48.02%           
  Complexity     6668     6668           
=========================================
  Files           409      409           
  Lines         46120    46122    +2     
  Branches       6503     6502    -1     
=========================================
+ Hits          22151    22152    +1     
- Misses        21559    21560    +1     
  Partials       2410     2410           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@HashEngineering HashEngineering merged commit b2155fb into master Dec 23, 2023
7 checks passed
@HashEngineering HashEngineering deleted the bugfix-auth-keys-reset branch January 10, 2024 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants