Skip to content

Conversation

thephez
Copy link
Collaborator

@thephez thephez commented Aug 18, 2025

Issue being fixed or feature implemented

PR linting is failing unnecessarily because we haven't added "wasm-sdk" to scope.

What was done?

Added "wasm-sdk" as valid scope

How Has This Been Tested?

N/A

Breaking Changes

None

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have added "!" to the title and described breaking changes in the corresponding section if my code contains any
  • I have made corresponding changes to the documentation if needed

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

Summary by CodeRabbit

  • Chores
    • Updated PR title validation to include “wasm-sdk” as an allowed scope, aligning CI checks with current naming and reducing false negatives during reviews. This streamlines contributor workflow and improves release notes/changelog categorization. Applies to pull request automation only. No user-facing changes. No runtime impact or behavior changes.

@thephez thephez added this to the v2.1 milestone Aug 18, 2025
Copy link
Contributor

coderabbitai bot commented Aug 18, 2025

Walkthrough

Updated the PR title validation in .github/workflows/pr.yml by adding "wasm-sdk" to the allowed scopes list for PR titles.

Changes

Cohort / File(s) Summary
CI workflow configuration
.github/workflows/pr.yml
Added "wasm-sdk" to the allowed PR title scopes in the validation step.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

I twitch my whiskers—scope anew!
“wasm-sdk” hops into the queue.
In titles neat, the checks align,
CI nods with a subtle sign.
Carrot commits and merges bright—
Thump-thump, the pipeline’s light! 🥕✨

Tip

🔌 Remote MCP (Model Context Protocol) integration is now available!

Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats.

✨ Finishing Touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch thephez-patch-1

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@thephez thephez requested a review from pauldelucia August 18, 2025 21:28
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
.github/workflows/pr.yml (1)

33-51: Optional: Keep scopes ordered for readability and fewer merge conflicts.

Consider alphabetizing the scopes list (or grouping related items, e.g., placing wasm-sdk near sdk) to make scanning easier and reduce churn in future edits.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

💡 Knowledge Base configuration:

  • MCP integration is disabled by default for public repositories
  • Jira integration is disabled by default for public repositories
  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between bcdda30 and d620328.

📒 Files selected for processing (1)
  • .github/workflows/pr.yml (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: Build JS packages / Build JS
🔇 Additional comments (2)
.github/workflows/pr.yml (2)

33-51: Addition of "wasm-sdk" scope is correct and resolves the PR title lint failure.

Given requireScope: false, titles without a scope still pass, and titles that include a scope now accept wasm-sdk. This change aligns the linter with actual usage.


33-51: Confirmed: Only .github/workflows/pr.yml enforces commit scopes
No commitlint or other CI configs with scope‐lists were found in the repository. Updating the scopes block in .github/workflows/pr.yml to include wasm-sdk is sufficient.

@QuantumExplorer QuantumExplorer merged commit 33ad0b7 into v2.1-dev Aug 19, 2025
18 of 19 checks passed
@QuantumExplorer QuantumExplorer deleted the thephez-patch-1 branch August 19, 2025 01:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants