-
Notifications
You must be signed in to change notification settings - Fork 44
chore: add wasm-sdk as scope for pr linting #2731
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughUpdated the PR title validation in .github/workflows/pr.yml by adding "wasm-sdk" to the allowed scopes list for PR titles. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
Tip 🔌 Remote MCP (Model Context Protocol) integration is now available!Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats. ✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
.github/workflows/pr.yml (1)
33-51
: Optional: Keep scopes ordered for readability and fewer merge conflicts.Consider alphabetizing the scopes list (or grouping related items, e.g., placing wasm-sdk near sdk) to make scanning easier and reduce churn in future edits.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (1)
.github/workflows/pr.yml
(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Build JS packages / Build JS
🔇 Additional comments (2)
.github/workflows/pr.yml (2)
33-51
: Addition of "wasm-sdk" scope is correct and resolves the PR title lint failure.Given requireScope: false, titles without a scope still pass, and titles that include a scope now accept wasm-sdk. This change aligns the linter with actual usage.
33-51
: Confirmed: Only.github/workflows/pr.yml
enforces commit scopes
Nocommitlint
or other CI configs with scope‐lists were found in the repository. Updating thescopes
block in.github/workflows/pr.yml
to includewasm-sdk
is sufficient.
Issue being fixed or feature implemented
PR linting is failing unnecessarily because we haven't added "wasm-sdk" to scope.
What was done?
Added "wasm-sdk" as valid scope
How Has This Been Tested?
N/A
Breaking Changes
None
Checklist:
For repository code-owners and collaborators only
Summary by CodeRabbit