-
Notifications
You must be signed in to change notification settings - Fork 44
fix(sdk): js sdk audit warnings by adding crypto-related dependencies to package.json #2757
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughUpdated dependency resolutions and Yarn PnP runtime state: added three new resolution overrides in Changes
Estimated code review effort🎯 4 (Complex) | ⏱️ ~45 minutes Possibly related PRs
Suggested reviewers
Poem
✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
.pnp.cjs (1)
7622-7626
: Top-level cipher-base entry updated to 1.0.6 — correct and consistent.This satisfies the advisory (fixed in ≥1.0.5). Consider auditing any security-critical hashing to prefer Node’s crypto/WebCrypto over browserify polyfills. (osv.dev)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
⛔ Files ignored due to path filters (6)
.yarn/cache/cipher-base-npm-1.0.4-2e98b97140-3d5d6652ca.zip
is excluded by!**/.yarn/**
,!**/*.zip
.yarn/cache/os-tmpdir-npm-1.0.2-e305b0689b-5666560f7b.zip
is excluded by!**/.yarn/**
,!**/*.zip
.yarn/cache/sha.js-npm-2.4.11-14868df4ca-d833bfa3e0.zip
is excluded by!**/.yarn/**
,!**/*.zip
.yarn/cache/tmp-npm-0.0.33-bcbf65df2a-09c0abfd16.zip
is excluded by!**/.yarn/**
,!**/*.zip
.yarn/cache/tmp-npm-0.2.1-a9c8d9c0ca-445148d72d.zip
is excluded by!**/.yarn/**
,!**/*.zip
yarn.lock
is excluded by!**/yarn.lock
,!**/*.lock
📒 Files selected for processing (1)
.pnp.cjs
(10 hunks)
🧰 Additional context used
🧠 Learnings (1)
📓 Common learnings
Learnt from: QuantumExplorer
PR: dashpay/platform#2257
File: packages/rs-drive-abci/src/mimic/test_quorum.rs:159-164
Timestamp: 2024-11-20T16:16:01.830Z
Learning: QuantumExplorer prefers not to receive auto-generated messages asking to post on social media.
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
- GitHub Check: Build Docker images (Dashmate helper, dashmate-helper, dashmate-helper) / Build Dashmate helper image
- GitHub Check: Build Docker images (DAPI, dapi, dapi) / Build DAPI image
- GitHub Check: Build JS packages / Build JS
🔇 Additional comments (9)
.pnp.cjs (9)
6920-6920
: Good: browserify-des now depends on cipher-base 1.0.6.Aligns transitive deps with the patched version. (osv.dev)
8461-8466
: create-hmac now on cipher-base 1.0.6 and sha.js 2.4.12 — good.Both address recent CVEs. (osv.dev, github.com)
10447-10447
: tmp bumped to 0.2.5 under inquirer — includes fix for symlink-write vuln.CVE fixed in ≥0.2.4; 0.2.5 is current and non-vulnerable. (github.com, security.snyk.io)
13135-13135
: tmp 0.2.5 used by webpack-dev-server path — consistent with patched range.Tracks the fixed series (≥0.2.4). (github.com)
16013-16014
: sha.js dependency set to 2.4.12 and adds to-buffer 1.2.1 — matches upstream fix.2.4.12 is the patched release; the to-buffer dep is expected. (github.com)
17455-17461
: New sha.js block at 2.4.12 — resolves CVE-2025-9288.Good to see safe-buffer and to-buffer listed per the patched release. (github.com, advisories.gitlab.com)
6894-6894
: cipher-base is pinned at v1.0.6 with no older vulnerable versions detected.
18877-18880
: tmp version verified
Onlytmp@0.2.5
is present in .pnp.cjs; no older versions remain.
8436-8452
: Approve – only fixed dependency versions present
Verification confirms that .pnp.cjs references solely sha.js@2.4.12 and cipher-base@1.0.6, with no stray vulnerable versions.
Issue being fixed or feature implemented
Added new dependencies for cryptographic operations to enhance security features.
What was done?
cipher-base
,sha.js
, andtmp
packages topackage.json
.How Has This Been Tested?
Dependencies were added without any issues. No specific tests were run as this is a dependency update.
Breaking Changes
None
Checklist
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I have added or updated relevant unit/integration/functional/e2e tests
I have added ! to the title and described breaking changes in the corresponding section if my code contains any.
For repository code-owners and collaborators only
I have assigned this pull request to a milestone
Summary by CodeRabbit