Skip to content

Conversation

thephez
Copy link
Collaborator

@thephez thephez commented Sep 8, 2025

Issue being fixed or feature implemented

cargo fmt had not been run on wasm-sdk, so there were many import ordering, whitespace, etc. issues.

What was done?

Did a whitespace cleanup and ran a multi-step cargo fmt process to clean things up. View via https://github.com/dashpay/platform/pull/2766/files?diff=unified&w=1 to see without any of the trivial whitespace changes. Other than the commit that removed several unused imports, there are not functional changes.

How Has This Been Tested?

Ran tests

Breaking Changes

N/A

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have added "!" to the title and described breaking changes in the corresponding section if my code contains any
  • I have made corresponding changes to the documentation if needed

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

reorder_imports = false
reorder_modules = false
wrap_comments = false
format_strings = false
format_code_in_doc_comments = false
normalize_doc_attributes = false
@thephez thephez added this to the v2.1 milestone Sep 8, 2025
Copy link
Contributor

coderabbitai bot commented Sep 8, 2025

Caution

Review failed

An error occurred during the review process. Please try again later.

✨ Finishing Touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch wasm-sdk-style-cleanup

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@thephez thephez marked this pull request as ready for review September 8, 2025 19:23
@thephez
Copy link
Collaborator Author

thephez commented Sep 8, 2025

@coderabbitai review

Copy link
Contributor

coderabbitai bot commented Sep 8, 2025

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@QuantumExplorer QuantumExplorer merged commit b7550d2 into v2.1-dev Sep 8, 2025
30 of 34 checks passed
@QuantumExplorer QuantumExplorer deleted the wasm-sdk-style-cleanup branch September 8, 2025 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants