-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: implement headers first synchronization #428
Conversation
…ate-with-block-headers-stream
…ate-with-block-headers-stream
This pull request introduces 1 alert when merging 7175fde into 83d4e96 - view on LGTM.com new alerts:
|
This pull request introduces 2 alerts when merging da64713 into 7a5715c - view on LGTM.com new alerts:
|
This pull request introduces 3 alerts when merging 0d58ee7 into 7a5715c - view on LGTM.com new alerts:
|
…ate-with-block-headers-stream # Conflicts: # .pnp.cjs # yarn.lock
packages/wallet-lib/src/plugins/Workers/TransactionsSyncWorker/TransactionsReader.js
Outdated
Show resolved
Hide resolved
packages/wallet-lib/src/plugins/Workers/TransactionsSyncWorker/TransactionsReader.js
Outdated
Show resolved
Hide resolved
packages/wallet-lib/src/plugins/Workers/TransactionsSyncWorker/TransactionsReader.spec.js
Outdated
Show resolved
Hide resolved
packages/wallet-lib/src/plugins/Workers/TransactionsSyncWorker/TransactionsSyncWorker.spec.js
Outdated
Show resolved
Hide resolved
packages/wallet-lib/src/plugins/Workers/TransactionsSyncWorker/utils.js
Outdated
Show resolved
Hide resolved
packages/js-dapi-client/lib/BlockHeadersProvider/BlockHeadersProvider.js
Outdated
Show resolved
Hide resolved
packages/js-dapi-client/lib/BlockHeadersProvider/BlockHeadersReader.js
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please take a look at the comments
043fc1b
to
df6bf09
Compare
…ate-with-block-headers-stream
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's huge! Good job!
Issue being fixed or feature implemented
Feature implements headers first synchronization in Dash wallet and refines a way transactions obtaining their metadata
during the synchronization process
What was done?
Headers sync
TX sync
getTransaction
andgetBlockHeader
requests to DAPIdash-spv
Additional changes
Leftovers
TX Sync
SPV
// Will be done in a separate ticket
Storage
skipSynchronizationBeforeHeight
Misc
How Has This Been Tested?
Breaking Changes
Checklist:
For repository code-owners and collaborators only