Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: operations in configure.sh script were in a wrong order #876

Merged
merged 1 commit into from
Mar 30, 2023
Merged

build: operations in configure.sh script were in a wrong order #876

merged 1 commit into from
Mar 30, 2023

Conversation

jawid-h
Copy link
Collaborator

@jawid-h jawid-h commented Mar 30, 2023

Issue being fixed or feature implemented

Fixes operation order of dashmate configuration script

What was done?

  • updated scripts/configure.sh

How Has This Been Tested?

local env

Breaking Changes

None

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@jawid-h jawid-h requested a review from markin-io March 30, 2023 14:52
shumkov
shumkov approved these changes Mar 30, 2023
View reviewed changes
Copy link
Member

@shumkov shumkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@shumkov shumkov changed the title fix: operations in configure.sh script were in a wrong order build: operations in configure.sh script were in a wrong order Mar 30, 2023
@jawid-h jawid-h merged commit ea5ee73 into v0.24-dev Mar 30, 2023
@jawid-h jawid-h deleted the fix/invalid-order-of-setup branch March 30, 2023 15:49
QuantumExplorer pushed a commit that referenced this pull request Apr 20, 2023
@jawid-h @QuantumExplorer
build: operations in configure.sh script were in a wrong order (#876)
101a1c8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markin-io markin-io markin-io approved these changes

@shumkov shumkov shumkov approved these changes

@antouhou antouhou Awaiting requested review from antouhou

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jawid-h @shumkov @markin-io