Skip to content

build: operations in configure.sh script were in a wrong order#876

Merged
jawid-h merged 1 commit into
v0.24-devfrom
fix/invalid-order-of-setup
Mar 30, 2023
Merged

build: operations in configure.sh script were in a wrong order#876
jawid-h merged 1 commit into
v0.24-devfrom
fix/invalid-order-of-setup

Conversation

@jawid-h

@jawid-h jawid-h commented Mar 30, 2023

Copy link
Copy Markdown
Contributor

Issue being fixed or feature implemented

Fixes operation order of dashmate configuration script

What was done?

  • updated scripts/configure.sh

How Has This Been Tested?

local env

Breaking Changes

None

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@jawid-h jawid-h requested a review from markin-io March 30, 2023 14:52

@shumkov shumkov left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@shumkov shumkov changed the title fix: operations in configure.sh script were in a wrong order build: operations in configure.sh script were in a wrong order Mar 30, 2023
@jawid-h jawid-h merged commit ea5ee73 into v0.24-dev Mar 30, 2023
@jawid-h jawid-h deleted the fix/invalid-order-of-setup branch March 30, 2023 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants