fix: wrong public keys signing #1027
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What was the issue? |
|
Yeah, good question. |
markin-io
reviewed
May 4, 2023
markin-io
reviewed
May 4, 2023
shumkov
reviewed
May 4, 2023
| // Own ST fields | ||
| pub public_keys: Vec<IdentityPublicKeyInCreationWithWitness>, | ||
| // The signable | ||
| #[platform_signable(into = "Vec<IdentityPublicKeyInCreationSignable>")] |
markin-io
approved these changes
May 4, 2023
shumkov
requested changes
May 4, 2023
| @@ -1,4 +1,7 @@ | |||
| use crate::ProtocolError; | |||
| use crate::identity::KeyType; | |||
There was a problem hiding this comment.
Shall we put it encoding module?
| use dashcore::signer; | ||
|
|
||
| impl PlatformMessageSignable for &[u8] { | ||
| fn verify_signature( |
There was a problem hiding this comment.
Since this function can be used outside of validation functions it should return own errors which should be transformed to consensus errors in validation function.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
There was an issue with signing public keys that has now been resolved. Previously keys were signing only the key which is not secure. Now they are signing the whole state transition.
What was done?
How Has This Been Tested?
Breaking Changes
Checklist:
For repository code-owners and collaborators only