refactor: cleaned abci execution module #1039
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antouhou
reviewed
May 8, 2023
| identity, | ||
| operations, | ||
| } | ||
| | ExecutionEvent::PaidDriveEvent { |
There was a problem hiding this comment.
Not to this PR, but generally for the future - I'm wondering if there's a DriveEvent suffix, do you think it might be valuable to create a separate enum for the DriveEvent?
There was a problem hiding this comment.
I don't think I understand your question.
antouhou
approved these changes
May 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
What was done?
Moved some files around and added documentation comments.
How Has This Been Tested?
Breaking Changes
Checklist:
For repository code-owners and collaborators only