Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: merkle root from the diff doesn't match calculated merkle root #1189

Merged
merged 1 commit into from
Jun 22, 2023

Conversation

shumkov
Copy link
Member

@shumkov shumkov commented Jun 22, 2023

Issue being fixed or feature implemented

Drive fails with Core 19.2:

      err: {
        "type": "Error",
          "message": "Merkle root from the diff doesn't match calculated merkle root after diff is applied",
          "stack":
        Error: Merkle root from the diff doesn't match calculated merkle root after diff is applied
        at SimplifiedMNList.applyDiff (/platform/.yarn/cache/@dashevo-dashcore-lib-npm-0.20.8-d3d76b93b6-937b88a28a.zip/node_modules/@dashevo/dashcore-lib/lib/deterministicmnlist/SimplifiedMNList.js:86:11)
        at new SimplifiedMNList (/platform/.yarn/cache/@dashevo-dashcore-lib-npm-0.20.8-d3d76b93b6-937b88a28a.zip/node_modules/@dashevo/dashcore-lib/lib/deterministicmnlist/SimplifiedMNList.js:42:10)
        at new SimplifiedMNListStore (/platform/.yarn/cache/@dashevo-dashcore-lib-npm-0.20.8-d3d76b93b6-937b88a28a.zip/node_modules/@dashevo/dashcore-lib/lib/deterministicmnlist/SimplifiedMNListStore.js:42:31)
        at SimplifiedMasternodeList.applyDiffs (/platform/packages/js-drive/lib/core/SimplifiedMasternodeList.js:19:20)
        at updateSimplifiedMasternodeList (/platform/packages/js-drive/lib/core/updateSimplifiedMasternodeListFactory.js:84:32)
        at processTicksAndRejections (node:internal/process/task_queues:96:5)
        at async initChainHandler (/platform/packages/js-drive/lib/abci/handlers/initChainHandlerFactory.js:77:5)
        at async Connection.handleRequest (/platform/.yarn/cache/@dashevo-abci-https-9fb519f2ca-aaf41ab7fa.zip/node_modules/@dashevo/abci/lib/handleRequestFactory.js:55:29)
        at async Connection.readNextRequest (/platform/.yarn/cache/@dashevo-abci-https-9fb519f2ca-aaf41ab7fa.zip/node_modules/@dashevo/abci/lib/Connection.js:176:18)
      }

What was done?

How Has This Been Tested?

None

Breaking Changes

None

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@shumkov shumkov changed the base branch from v0.25-dev to master June 22, 2023 13:00
@shumkov shumkov changed the title fix/drive/merkle_diff fix: merkle root from the diff doesn't match calculated merkle root Jun 22, 2023
@shumkov shumkov added this to the v0.24.x milestone Jun 22, 2023
@shumkov shumkov marked this pull request as ready for review June 22, 2023 13:04
@shumkov shumkov requested a review from antouhou as a code owner June 22, 2023 13:04
@shumkov shumkov merged commit 5bf4ea8 into master Jun 22, 2023
@shumkov shumkov deleted the fix/drive/merkle_diff branch June 22, 2023 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants