Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: withdrawals finalization #1601

Merged
merged 150 commits into from
Feb 6, 2024
Merged

feat!: withdrawals finalization #1601

merged 150 commits into from
Feb 6, 2024

Conversation

markin-io
Copy link
Contributor

@markin-io markin-io commented Nov 27, 2023 •
edited by shumkov
Loading

Issue being fixed or feature implemented

Finished withdrawal part of the bridging functionality between core and platform

What was done?

Drive-ABCI

  • Handling of the core TX signing and broadcasting
  • Handling of the withdrawal document status updates (queued, pooled, broadcasted, complete, expired)

Tenderdash

  • Reworked logic of signing of the vote extensions to support withdrawal request id

JS-SDK

  • Added functionality to withdraw credits

How Has This Been Tested?

  • Added e2e test in platform-test-suite
  • Extra unit and integration tests in other packages

Breaking Changes

The initial state is changed.

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have added "!" to the title and described breaking changes in the corresponding section if my code contains any
  • I have made corresponding changes to the documentation if needed

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

QuantumExplorer and others added 13 commits November 21, 2023 18:04
markin-io and others added 14 commits December 5, 2023 13:14
@markin-io
test(rs-drive-abci): cover COMPLETE statuses of withdrawals
a7ada91
@markin-io
fix(wasm-dpp): missing data trigger errors
0e26221
@markin-io
test(platform-test-suite): test that regular identities cannot initia…
21f18e7 
…te withdrawals
@markin-io
wip: add loop to check balance
a3e1ea7
@markin-io
feat(rs-drive-abci): sign, verify and broadcast asset unlock tx
cea5cb8
@markin-io
fix(rs-drive-abci): every node sends asset unlock transactions
1b491f6
@markin-io
fix(rs-drive-abci): failing send_raw_transaction affects finalize_block
8ce3989
@markin-io
fix(rs-drive-abci): wrong QuorumHash::hash
e8cc763
@ogabrielides
fix(rs-drive-abci): Reverse quorum_hash
1abdcc2
@ogabrielides
fix(rs-drive-abci): partially DIP-7 implementation for asset unlock
b3ae49b
@ogabrielides
wip: improve vote extension construction
14409ba
@markin-io
feat(rs-drive-abci): assetunlock sighash
067dfdd
@markin-io
wip(test-suite): fix initial balance
b5a34ac
@markin-io
wip(drive): sign raw msg vote extension
f8a3818
QuantumExplorer
QuantumExplorer requested changes Feb 5, 2024
View reviewed changes
.../state_transition/state_transitions/identity/identity_credit_withdrawal_transition/v0/mod.rs Outdated Show resolved Hide resolved
packages/rs-platform-version/src/version/drive_abci_versions.rs Outdated Show resolved Hide resolved
...latform_events/withdrawals/append_signatures_and_broadcast_withdrawal_transactions/v0/mod.rs Outdated Show resolved Hide resolved
...latform_events/withdrawals/append_signatures_and_broadcast_withdrawal_transactions/v0/mod.rs Outdated Show resolved Hide resolved
...latform_events/withdrawals/append_signatures_and_broadcast_withdrawal_transactions/v0/mod.rs Outdated Show resolved Hide resolved
packages/rs-drive/src/drive/identity/withdrawals/documents.rs Outdated Show resolved Hide resolved
packages/rs-drive/src/drive/identity/withdrawals/documents.rs Outdated Show resolved Hide resolved
...s/rs-drive/src/state_transition_action/identity/identity_credit_withdrawal/v0/transformer.rs Outdated Show resolved Hide resolved
packages/rs-drive-abci/src/rpc/core.rs Outdated Show resolved Hide resolved
...-abci/src/execution/platform_events/withdrawals/update_broadcasted_withdrawals_status/mod.rs Outdated Show resolved Hide resolved
shumkov
shumkov approved these changes Feb 6, 2024
View reviewed changes
Copy link
Member

@shumkov shumkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job, everyone! 👍

@shumkov shumkov merged commit 9591752 into v1.0-dev Feb 6, 2024
87 checks passed
@shumkov shumkov deleted the feat/withdrawalFinalization branch February 6, 2024 14:47
@shumkov shumkov changed the title feat(drive): withdrawals finalization feat: withdrawals finalization Feb 6, 2024
@shumkov shumkov changed the title feat: withdrawals finalization feat!: withdrawals finalization Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lklimek lklimek lklimek left review comments

@shumkov shumkov shumkov approved these changes

@QuantumExplorer QuantumExplorer QuantumExplorer approved these changes

@antouhou antouhou Awaiting requested review from antouhou

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.0.0
Development

Successfully merging this pull request may close these issues.
5 participants
@markin-io @shumkov @lklimek @QuantumExplorer @ogabrielides