Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove votes of removed masternodes when collateral is moved #1894

Conversation

QuantumExplorer
Copy link
Member

Issue being fixed or feature implemented

If a masternode would vote, they could move their collateral, and then issue a new vote, which would in essence allow people to vote forever, and break the system

What was done?

When a masternode is removed from the masternode list their votes are removed.

How Has This Been Tested?

Added a test.

Breaking Changes

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have added "!" to the title and described breaking changes in the corresponding section if my code contains any
  • I have made corresponding changes to the documentation if needed

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@QuantumExplorer QuantumExplorer merged commit ff4f81b into feat/contestedDocumentResolutionWithMasternodeVoting Jun 18, 2024
2 checks passed
@QuantumExplorer QuantumExplorer deleted the feat/onlyAllowMasternodesOverFourHoursOldToVote branch June 18, 2024 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants