Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sdk)!: overflow when using &&sdk in DapiRequestExecutor #2060

Merged
merged 1 commit into from
Aug 20, 2024

Conversation

lklimek
Copy link
Contributor

@lklimek lklimek commented Aug 16, 2024

Issue being fixed or feature implemented

Calling request.execute(&&Sdk) causes overflow error.

What was done?

Removed affected code.
Now, the compiler will show error when trying to use double-ref.

How Has This Been Tested?

GHA

Breaking Changes

Use of double-ref to Sdk in DapiRequestExecutor::execute() is not possible anymore.
You must deref or clone Sdk.

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have added "!" to the title and described breaking changes in the corresponding section if my code contains any
  • I have made corresponding changes to the documentation if needed

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@lklimek lklimek added this to the v1.1.0 milestone Aug 16, 2024
@QuantumExplorer QuantumExplorer merged commit 0f0e301 into v1.1-dev Aug 20, 2024
24 checks passed
@QuantumExplorer QuantumExplorer deleted the fix/sdk-double-ref-panic branch August 20, 2024 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants