fix(drive-abci)!: fix wrong fields in dash top level domain #2065
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ogabrielides
previously approved these changes
Aug 21, 2024
shumkov
requested changes
Aug 21, 2024
| @@ -139,6 +136,8 @@ impl<C> Platform<C> { | |||
| .into_btree_string_map() | |||
| .map_err(|e| Error::Protocol(ProtocolError::ValueError(e)))?; | |||
|
|
|||
| println!("{:?}", document_stub_properties); | |||
|
Merging as this had passed before we had to remove the println |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
We were experiencing a few issues with an empty string being present as a tree in the domain table, this caused the contract based translation of the drive document queries to path queries to go a bit haywire which led to the result that an item that was expected would not be inserted due to a limit going down by 1 because of an empty tree.
What was done?
Fixed the dash tld.
How Has This Been Tested?
Not very well tested, however this is most likely the issue. I checked a strategy test to make sure things worked well after this change, however since the original issue was very hard to reproduce, we will only really be able to see if the fix works when it goes to Testnet.
Breaking Changes
This fix is a breaking change.
Checklist:
For repository code-owners and collaborators only