Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(wasm dpp): validate state transition key signature #806

Merged
merged 3 commits into from
Feb 24, 2023
Merged

feat(wasm dpp): validate state transition key signature #806

merged 3 commits into from
Feb 24, 2023

Conversation

markin-io
Copy link
Contributor

@markin-io markin-io commented Feb 23, 2023 •
edited
Loading

Issue being fixed or feature implemented

  • Refactored validate_state_transition_key_signature to use identity balance instead of identity
  • Implemented wasm binding and tests

What was done?

How Has This Been Tested?

Breaking Changes

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@markin-io markin-io added this to the v0.24.0 milestone Feb 23, 2023
fominok
fominok previously approved these changes Feb 23, 2023
View reviewed changes
shumkov
shumkov previously approved these changes Feb 23, 2023
View reviewed changes
@markin-io markin-io dismissed stale reviews from shumkov and fominok via 682ce89 February 24, 2023 10:29
shumkov
shumkov approved these changes Feb 24, 2023
View reviewed changes
Copy link
Member

@shumkov shumkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@markin-io markin-io merged commit 6f9756e into v0.24-dev Feb 24, 2023
@markin-io markin-io deleted the feat/wasm-dpp/validate_state_transition_key_signature branch February 24, 2023 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shumkov shumkov shumkov approved these changes

@fominok fominok fominok left review comments

@antouhou antouhou Awaiting requested review from antouhou

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.24.0
Development

Successfully merging this pull request may close these issues.
3 participants
@markin-io @shumkov @fominok