Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(wasm-dpp): identity transitions additional functionality #855

Merged
merged 12 commits into from
Mar 24, 2023

Conversation

markin-io
Copy link
Contributor

Issue being fixed or feature implemented

PR adds additional functionality to identity transitions bindings and fixes couple of bugs related to basic validation of state transitions

What was done?

  • Added toBuffer(), setSignature() setSignaturePublicKeyId() methods to ST bindings
  • Fixed bugs with ST type serialization
  • Added fixtures to use in DAPI tests
  • Fixed bugs with to_object in identity_update_transition

How Has This Been Tested?

  • CI

Breaking Changes

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@markin-io markin-io added this to the v0.24.0 milestone Mar 23, 2023
@markin-io markin-io merged commit a60affc into v0.24-dev Mar 24, 2023
@markin-io markin-io deleted the fix/dpp/identity-transitions branch March 24, 2023 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants