Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(dashmate)!: multiple issues in the reset command #991

Merged
merged 4 commits into from
Apr 28, 2023
Merged

fix(dashmate)!: multiple issues in the reset command #991

merged 4 commits into from
Apr 28, 2023

Conversation

shumkov
Copy link
Member

@shumkov shumkov commented Apr 28, 2023 •
edited
Loading

Issue being fixed or feature implemented

The reset and group reset commands do not work with --force flag

What was done?

  • Remove containers and volumes in two steps since docker compose rm --stop --volumes doesn't work properly.
  • Fixed group soft reset
  • Refactored reset logic
  • Renamed the --platfrom-only to --platform flag follow naming convention with other commands

How Has This Been Tested?

Manually

Breaking Changes

  • The --platfrom-only flag is renamed to --platform

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@shumkov shumkov requested a review from antouhou as a code owner April 28, 2023 06:42
@shumkov shumkov changed the title fix(dashmate): force reset fails with volume deletion fix(dashmate): multiple issues in the reset command Apr 28, 2023
@shuplenkov shuplenkov changed the title fix(dashmate): multiple issues in the reset command fix(dashmate)!: multiple issues in the reset command Apr 28, 2023
@shumkov shumkov merged commit 0e263be into v0.24-dev Apr 28, 2023
@shumkov shumkov deleted the fix/dashmate/soft_reset_and_force_flag branch April 28, 2023 10:13
markin-io pushed a commit that referenced this pull request Apr 28, 2023
@shumkov @markin-io
fix(dashmate)!: multiple issues in the reset command (#991)
2e984df
This was referenced May 1, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shuplenkov shuplenkov shuplenkov approved these changes

@antouhou antouhou Awaiting requested review from antouhou

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shumkov @shuplenkov