backport: merge result of tendermint/master with v0.8-dev #376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps [actions/checkout](https://github.com/actions/checkout) from 2.4.0 to 3. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/actions/checkout/releases">actions/checkout's releases</a>.</em></p> <blockquote> <h2>v3.0.0</h2> <ul> <li>Update default runtime to node16</li> </ul> </blockquote> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/actions/checkout/blob/main/CHANGELOG.md">actions/checkout's changelog</a>.</em></p> <blockquote> <h1>Changelog</h1> <h2>v2.3.1</h2> <ul> <li><a href="https://github-redirect.dependabot.com/actions/checkout/pull/284">Fix default branch resolution for .wiki and when using SSH</a></li> </ul> <h2>v2.3.0</h2> <ul> <li><a href="https://github-redirect.dependabot.com/actions/checkout/pull/278">Fallback to the default branch</a></li> </ul> <h2>v2.2.0</h2> <ul> <li><a href="https://github-redirect.dependabot.com/actions/checkout/pull/258">Fetch all history for all tags and branches when fetch-depth=0</a></li> </ul> <h2>v2.1.1</h2> <ul> <li>Changes to support GHES (<a href="https://github-redirect.dependabot.com/actions/checkout/pull/236">here</a> and <a href="https://github-redirect.dependabot.com/actions/checkout/pull/248">here</a>)</li> </ul> <h2>v2.1.0</h2> <ul> <li><a href="https://github-redirect.dependabot.com/actions/checkout/pull/191">Group output</a></li> <li><a href="https://github-redirect.dependabot.com/actions/checkout/pull/199">Changes to support GHES alpha release</a></li> <li><a href="https://github-redirect.dependabot.com/actions/checkout/pull/184">Persist core.sshCommand for submodules</a></li> <li><a href="https://github-redirect.dependabot.com/actions/checkout/pull/163">Add support ssh</a></li> <li><a href="https://github-redirect.dependabot.com/actions/checkout/pull/179">Convert submodule SSH URL to HTTPS, when not using SSH</a></li> <li><a href="https://github-redirect.dependabot.com/actions/checkout/pull/157">Add submodule support</a></li> <li><a href="https://github-redirect.dependabot.com/actions/checkout/pull/144">Follow proxy settings</a></li> <li><a href="https://github-redirect.dependabot.com/actions/checkout/pull/141">Fix ref for pr closed event when a pr is merged</a></li> <li><a href="https://github-redirect.dependabot.com/actions/checkout/pull/128">Fix issue checking detached when git less than 2.22</a></li> </ul> <h2>v2.0.0</h2> <ul> <li><a href="https://github-redirect.dependabot.com/actions/checkout/pull/108">Do not pass cred on command line</a></li> <li><a href="https://github-redirect.dependabot.com/actions/checkout/pull/107">Add input persist-credentials</a></li> <li><a href="https://github-redirect.dependabot.com/actions/checkout/pull/104">Fallback to REST API to download repo</a></li> </ul> <h2>v2 (beta)</h2> <ul> <li>Improved fetch performance <ul> <li>The default behavior now fetches only the SHA being checked-out</li> </ul> </li> <li>Script authenticated git commands <ul> <li>Persists <code>with.token</code> in the local git config</li> <li>Enables your scripts to run authenticated git commands</li> <li>Post-job cleanup removes the token</li> <li>Coming soon: Opt out by setting <code>with.persist-credentials</code> to <code>false</code></li> </ul> </li> <li>Creates a local branch <ul> <li>No longer detached HEAD when checking out a branch</li> <li>A local branch is created with the corresponding upstream branch set</li> </ul> </li> <li>Improved layout</li> </ul> </blockquote> <p>... (truncated)</p> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/actions/checkout/commit/a12a3943b4bdde767164f792f33f40b04645d846"><code>a12a394</code></a> update readme for v3 (<a href="https://github-redirect.dependabot.com/actions/checkout/issues/708">#708</a>)</li> <li><a href="https://github.com/actions/checkout/commit/8f9e05e482293f862823fcca12d9eddfb3723131"><code>8f9e05e</code></a> Update to node 16 (<a href="https://github-redirect.dependabot.com/actions/checkout/issues/689">#689</a>)</li> <li><a href="https://github.com/actions/checkout/commit/230611dbd0eb52da1e1f4f7bc8bb0c3a339fc8b7"><code>230611d</code></a> Change secret name for PAT to not start with GITHUB_ (<a href="https://github-redirect.dependabot.com/actions/checkout/issues/623">#623</a>)</li> <li>See full diff in <a href="https://github.com/actions/checkout/compare/v2.4.0...v3">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details>
Bumps [docker/login-action](https://github.com/docker/login-action) from 1.13.0 to 1.14.1. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/docker/login-action/releases">docker/login-action's releases</a>.</em></p> <blockquote> <h2>v1.14.1</h2> <ul> <li>Revert to Node 12 as default runtime to fix issue for GHE users (<a href="https://github-redirect.dependabot.com/docker/login-action/issues/160">#160</a>)</li> </ul> <h2>v1.14.0</h2> <ul> <li>Update to node 16 (<a href="https://github-redirect.dependabot.com/docker/login-action/issues/158">#158</a>)</li> <li>Bump <code>@aws-sdk/client-ecr</code> from 3.45.0 to 3.53.0 (<a href="https://github-redirect.dependabot.com/docker/login-action/issues/157">#157</a>)</li> <li>Bump <code>@aws-sdk/client-ecr-public</code> from 3.45.0 to 3.53.0 (<a href="https://github-redirect.dependabot.com/docker/login-action/issues/156">#156</a>)</li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/docker/login-action/commit/dd4fa0671be5250ee6f50aedf4cb05514abda2c7"><code>dd4fa06</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/docker/login-action/issues/160">#160</a> from crazy-max/node12</li> <li><a href="https://github.com/docker/login-action/commit/4e3538592e4d58e2b870040b10d65858ab0c377b"><code>4e35385</code></a> Revert to Node 12 as default runtime</li> <li><a href="https://github.com/docker/login-action/commit/bb984efc561711aaa26e433c32c3521176eae55b"><code>bb984ef</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/docker/login-action/issues/156">#156</a> from docker/dependabot/npm_and_yarn/aws-sdk/client-ec...</li> <li><a href="https://github.com/docker/login-action/commit/722888132b52d82f9e800a76b18ad2573c2aa56d"><code>7228881</code></a> Update generated content</li> <li><a href="https://github.com/docker/login-action/commit/17780b56b7c28c4eed063a4ee9732cf55139d75b"><code>17780b5</code></a> Bump <code>@aws-sdk/client-ecr-public</code> from 3.45.0 to 3.53.0</li> <li><a href="https://github.com/docker/login-action/commit/39857b3b45f7575a6b32d567326de5ab975ec0b4"><code>39857b3</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/docker/login-action/issues/157">#157</a> from docker/dependabot/npm_and_yarn/aws-sdk/client-ec...</li> <li><a href="https://github.com/docker/login-action/commit/5fcc728422b1d9a3c0f8cd595f8fb8f9b7913076"><code>5fcc728</code></a> Update generated content</li> <li><a href="https://github.com/docker/login-action/commit/9fb8721eb962ea53bd4e46a074098e8177970818"><code>9fb8721</code></a> Bump <code>@aws-sdk/client-ecr</code> from 3.45.0 to 3.53.0</li> <li><a href="https://github.com/docker/login-action/commit/4e3c9375bb2de165082a94f079d3fbaccbb8a98b"><code>4e3c937</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/docker/login-action/issues/158">#158</a> from crazy-max/node-16</li> <li><a href="https://github.com/docker/login-action/commit/4b59a429dba6f6bf641264a15801b79fc2266e54"><code>4b59a42</code></a> update to node 16</li> <li>See full diff in <a href="https://github.com/docker/login-action/compare/v1.13.0...v1.14.1">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details>
…#8074) Bumps [golangci/golangci-lint-action](https://github.com/golangci/golangci-lint-action) from 2.5.2 to 3.1.0. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/golangci/golangci-lint-action/releases">golangci/golangci-lint-action's releases</a>.</em></p> <blockquote> <h2>v3.1.0</h2> <h2>What's Changed</h2> <h3>New features</h3> <ul> <li>Allow to disable caching completely by <a href="https://github.com/tdabasinskas"><code>@tdabasinskas</code></a> in <a href="https://github-redirect.dependabot.com/golangci/golangci-lint-action/pull/351">golangci/golangci-lint-action#351</a></li> </ul> <h3>CI</h3> <ul> <li>ci(dep): Add step to commit changes if PR has dependencies label by <a href="https://github.com/sayboras"><code>@sayboras</code></a> in <a href="https://github-redirect.dependabot.com/golangci/golangci-lint-action/pull/108">golangci/golangci-lint-action#108</a></li> </ul> <h3>Dependabot</h3> <ul> <li>build(deps-dev): bump eslint from 8.9.0 to 8.10.0 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://github-redirect.dependabot.com/golangci/golangci-lint-action/pull/405">golangci/golangci-lint-action#405</a></li> </ul> <h3>Misc</h3> <ul> <li>Update version to 3.1.0 in package.json by <a href="https://github.com/SVilgelm"><code>@SVilgelm</code></a> in <a href="https://github-redirect.dependabot.com/golangci/golangci-lint-action/pull/406">golangci/golangci-lint-action#406</a></li> <li>fix version in package-lock.json by <a href="https://github.com/SVilgelm"><code>@SVilgelm</code></a> in <a href="https://github-redirect.dependabot.com/golangci/golangci-lint-action/pull/407">golangci/golangci-lint-action#407</a></li> </ul> <h2>New Contributors</h2> <ul> <li><a href="https://github.com/tdabasinskas"><code>@tdabasinskas</code></a> made their first contribution in <a href="https://github-redirect.dependabot.com/golangci/golangci-lint-action/pull/351">golangci/golangci-lint-action#351</a></li> </ul> <p><strong>Full Changelog</strong>: <a href="https://github.com/golangci/golangci-lint-action/compare/v3...v3.1.0">https://github.com/golangci/golangci-lint-action/compare/v3...v3.1.0</a></p> <h2>v3.0.0</h2> <h2>What's Changed</h2> <ul> <li>Fix grammar in action.yml by <a href="https://github.com/abennett"><code>@abennett</code></a> in <a href="https://github-redirect.dependabot.com/golangci/golangci-lint-action/pull/356">golangci/golangci-lint-action#356</a></li> <li>Add description for permissions settings by <a href="https://github.com/sg0hsmt"><code>@sg0hsmt</code></a> in <a href="https://github-redirect.dependabot.com/golangci/golangci-lint-action/pull/298">golangci/golangci-lint-action#298</a></li> <li>Remove Setup-Go by <a href="https://github.com/StevenACoffman"><code>@StevenACoffman</code></a> in <a href="https://github-redirect.dependabot.com/golangci/golangci-lint-action/pull/403">golangci/golangci-lint-action#403</a></li> <li>Update all direct dependencies by <a href="https://github.com/SVilgelm"><code>@SVilgelm</code></a> in <a href="https://github-redirect.dependabot.com/golangci/golangci-lint-action/pull/404">golangci/golangci-lint-action#404</a></li> <li>139 Dependabot updates</li> </ul> <h2>New Contributors</h2> <ul> <li><a href="https://github.com/abennett"><code>@abennett</code></a> made their first contribution in <a href="https://github-redirect.dependabot.com/golangci/golangci-lint-action/pull/356">golangci/golangci-lint-action#356</a></li> <li><a href="https://github.com/sg0hsmt"><code>@sg0hsmt</code></a> made their first contribution in <a href="https://github-redirect.dependabot.com/golangci/golangci-lint-action/pull/298">golangci/golangci-lint-action#298</a></li> <li><a href="https://github.com/StevenACoffman"><code>@StevenACoffman</code></a> made their first contribution in <a href="https://github-redirect.dependabot.com/golangci/golangci-lint-action/pull/403">golangci/golangci-lint-action#403</a></li> </ul> <p><strong>Full Changelog</strong>: <a href="https://github.com/golangci/golangci-lint-action/compare/v2...v3.0.0">https://github.com/golangci/golangci-lint-action/compare/v2...v3.0.0</a></p> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/golangci/golangci-lint-action/commit/b517f99ae23d86ecc4c0dec08dcf48d2336abc29"><code>b517f99</code></a> fix version in package-lock.json (<a href="https://github-redirect.dependabot.com/golangci/golangci-lint-action/issues/407">#407</a>)</li> <li><a href="https://github.com/golangci/golangci-lint-action/commit/9636c5bc970c0b32ef536af763bb0d8c0ce43d06"><code>9636c5b</code></a> Update version to 3.1.0 in package.json (<a href="https://github-redirect.dependabot.com/golangci/golangci-lint-action/issues/406">#406</a>)</li> <li><a href="https://github.com/golangci/golangci-lint-action/commit/03e4befc7a48e128bca6688662b6c114c5f15ced"><code>03e4bef</code></a> ci(dep): Add step to commit changes if PR has dependencies label (<a href="https://github-redirect.dependabot.com/golangci/golangci-lint-action/issues/108">#108</a>)</li> <li><a href="https://github.com/golangci/golangci-lint-action/commit/cdfc708aebd36a8298403ef5d87a954d8fe174f7"><code>cdfc708</code></a> Allow to disable caching completely (<a href="https://github-redirect.dependabot.com/golangci/golangci-lint-action/issues/351">#351</a>)</li> <li><a href="https://github.com/golangci/golangci-lint-action/commit/7d5614c3ebb18b0b007c796cc4b8d5c10c738cde"><code>7d5614c</code></a> build(deps-dev): bump eslint from 8.9.0 to 8.10.0 (<a href="https://github-redirect.dependabot.com/golangci/golangci-lint-action/issues/405">#405</a>)</li> <li><a href="https://github.com/golangci/golangci-lint-action/commit/c675eb70db3aa26b496bc4e64da320480338d41b"><code>c675eb7</code></a> Update all direct dependencies (<a href="https://github-redirect.dependabot.com/golangci/golangci-lint-action/issues/404">#404</a>)</li> <li><a href="https://github.com/golangci/golangci-lint-action/commit/423fbafafc226b312a399e5a5c942041f5d6f24f"><code>423fbaf</code></a> Remove Setup-Go (<a href="https://github-redirect.dependabot.com/golangci/golangci-lint-action/issues/403">#403</a>)</li> <li><a href="https://github.com/golangci/golangci-lint-action/commit/bcfc6f96bb4349b5b132c5ee5dd004652378de94"><code>bcfc6f9</code></a> build(deps-dev): bump eslint-plugin-import from 2.25.3 to 2.25.4 (<a href="https://github-redirect.dependabot.com/golangci/golangci-lint-action/issues/402">#402</a>)</li> <li><a href="https://github.com/golangci/golangci-lint-action/commit/d34ac2aef3154747bff6d9bda0e3cf7b3dc06653"><code>d34ac2a</code></a> build(deps): bump setup-go from v2.1.4 to v2.2.0 (<a href="https://github-redirect.dependabot.com/golangci/golangci-lint-action/issues/401">#401</a>)</li> <li><a href="https://github.com/golangci/golangci-lint-action/commit/e4b538ed37b93de2fd7b5b1f481eee1b634a7c6f"><code>e4b538e</code></a> build(deps-dev): bump <code>@types/node</code> from 16.11.10 to 17.0.19 (<a href="https://github-redirect.dependabot.com/golangci/golangci-lint-action/issues/400">#400</a>)</li> <li>Additional commits viewable in <a href="https://github.com/golangci/golangci-lint-action/compare/v2.5.2...v3.1.0">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details>
The %w syntax is a fmt.Errorf thing, not supported by the testing package.
* statesync: avoid leaking a thread during tests * fix
Fixes #8052 again. Ideally we would have some way of detecting that this happens before merging, but the way we build docs right now is kind of complicated.
…igation (#8048) * reorganizing basic concepts, adding outline to navigate easy * Update spec/abci++/README.md Co-authored-by: Sergio Mena <sergio@informal.systems> * Update spec/abci++/abci++_basic_concepts_002_draft.md Co-authored-by: Sergio Mena <sergio@informal.systems> * Update spec/abci++/abci++_basic_concepts_002_draft.md Co-authored-by: Sergio Mena <sergio@informal.systems> * Update spec/abci++/abci++_basic_concepts_002_draft.md Co-authored-by: Sergio Mena <sergio@informal.systems> * Update spec/abci++/abci++_basic_concepts_002_draft.md Co-authored-by: Sergio Mena <sergio@informal.systems> * Update spec/abci++/abci++_basic_concepts_002_draft.md Co-authored-by: Sergio Mena <sergio@informal.systems> * Update spec/abci++/abci++_basic_concepts_002_draft.md Co-authored-by: Sergio Mena <sergio@informal.systems> * Update spec/abci++/abci++_basic_concepts_002_draft.md Co-authored-by: Sergio Mena <sergio@informal.systems> * Update spec/abci++/abci++_basic_concepts_002_draft.md Co-authored-by: Sergio Mena <sergio@informal.systems> * Update spec/abci++/abci++_basic_concepts_002_draft.md Co-authored-by: M. J. Fromberger <fromberger@interchain.io> * Update spec/abci++/abci++_basic_concepts_002_draft.md Co-authored-by: M. J. Fromberger <fromberger@interchain.io> * Update spec/abci++/abci++_basic_concepts_002_draft.md Co-authored-by: M. J. Fromberger <fromberger@interchain.io> * address problem with snapshot list data type * Update spec/abci++/abci++_basic_concepts_002_draft.md Co-authored-by: M. J. Fromberger <fromberger@interchain.io> * Update spec/abci++/abci++_basic_concepts_002_draft.md Co-authored-by: M. J. Fromberger <fromberger@interchain.io> * Update spec/abci++/abci++_basic_concepts_002_draft.md Co-authored-by: M. J. Fromberger <fromberger@interchain.io> * Update spec/abci++/abci++_basic_concepts_002_draft.md Co-authored-by: William Banfield <4561443+williambanfield@users.noreply.github.com> * Update spec/abci++/abci++_basic_concepts_002_draft.md Co-authored-by: M. J. Fromberger <fromberger@interchain.io> * clarify handling events in same-execution model * remove outdated text about vote extension singing * clarification apphash state-sync Co-authored-by: Sergio Mena <sergio@informal.systems> Co-authored-by: M. J. Fromberger <fromberger@interchain.io> Co-authored-by: William Banfield <4561443+williambanfield@users.noreply.github.com>
* node: pass eventbus at construction time * remove cruft
* add safe reset * undo change * remove unsafe * Update cmd/tendermint/commands/reset_priv_validator.go Co-authored-by: Thane Thomson <connect@thanethomson.com> * Update cmd/tendermint/commands/reset_priv_validator.go Co-authored-by: M. J. Fromberger <fromberger@interchain.io> * remove export comment Co-authored-by: Thane Thomson <connect@thanethomson.com> Co-authored-by: M. J. Fromberger <fromberger@interchain.io>
Bumps [google.golang.org/grpc](https://github.com/grpc/grpc-go) from 1.44.0 to 1.45.0. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/grpc/grpc-go/releases">google.golang.org/grpc's releases</a>.</em></p> <blockquote> <h2>Release 1.45.0</h2> <h1>Bug Fixes</h1> <ul> <li>xds/clusterresolver: pass cluster name to DNS child policy to be used in creds handshake (<a href="https://github-redirect.dependabot.com/grpc/grpc-go/issues/5119">#5119</a>)</li> <li>reflection: support dynamic messages (<a href="https://github-redirect.dependabot.com/grpc/grpc-go/issues/5180">#5180</a>) <ul> <li>Special Thanks: <a href="https://github.com/codebutler"><code>@codebutler</code></a></li> </ul> </li> </ul> <h1>Performance Improvements</h1> <ul> <li>wrr: improve randomWRR performance (<a href="https://github-redirect.dependabot.com/grpc/grpc-go/issues/5067">#5067</a>) <ul> <li>Special Thanks: <a href="https://github.com/huangchong94"><code>@huangchong94</code></a></li> </ul> </li> </ul> <h1>Behavior Changes</h1> <ul> <li>server: convert context errors returned by service handlers to status with the correct status code (<code>Canceled</code> or <code>DeadlineExceeded</code>), instead of <code>Unknown</code> (<a href="https://github-redirect.dependabot.com/grpc/grpc-go/issues/5156">#5156</a>)</li> </ul> <h1>New Features</h1> <ul> <li>reflection: add <code>NewServer(ServerOptions)</code> for creating a reflection server with advanced customizations (<a href="https://github-redirect.dependabot.com/grpc/grpc-go/issues/5197">#5197</a>)</li> <li>xds: support federation (<a href="https://github-redirect.dependabot.com/grpc/grpc-go/issues/5128">#5128</a>)</li> <li>xds/resource: accept Self as LDS's RDS config source and CDS's EDS config source (<a href="https://github-redirect.dependabot.com/grpc/grpc-go/issues/5152">#5152</a>)</li> <li>xds/bootstrap: add plugin system for credentials specified in bootstrap file (<a href="https://github-redirect.dependabot.com/grpc/grpc-go/issues/5136">#5136</a>)</li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/grpc/grpc-go/commit/a82cc96f07c960e02623688e4067ae6b7895334a"><code>a82cc96</code></a> Change version to 1.45.0 (<a href="https://github-redirect.dependabot.com/grpc/grpc-go/issues/5202">#5202</a>)</li> <li><a href="https://github.com/grpc/grpc-go/commit/011544f72939c85397b0e24378280e6075061cb1"><code>011544f</code></a> authz: add additional logs to sdk authz (<a href="https://github-redirect.dependabot.com/grpc/grpc-go/issues/5094">#5094</a>)</li> <li><a href="https://github.com/grpc/grpc-go/commit/18564ff61d5505d955c7bd1adc28e4f1ed96300c"><code>18564ff</code></a> reflection: improve server implementation (<a href="https://github-redirect.dependabot.com/grpc/grpc-go/issues/5197">#5197</a>)</li> <li><a href="https://github.com/grpc/grpc-go/commit/ec717cad7395d45698b57c1df1ae36b4dbaa33dd"><code>ec717ca</code></a> xds: minor cleanup in xdsclient bootstrap code (<a href="https://github-redirect.dependabot.com/grpc/grpc-go/issues/5195">#5195</a>)</li> <li><a href="https://github.com/grpc/grpc-go/commit/ebc30b8fc32e02f0ac5eff0ddbe4ccdca58bd8c4"><code>ebc30b8</code></a> reflection: use protobuf/reflect instead of go reflection, fix dynamic messag...</li> <li><a href="https://github.com/grpc/grpc-go/commit/46009ac902e2256a2675e6e7057d384f6fdc222d"><code>46009ac</code></a> transport: Add an Unwrap method to ConnectionError (<a href="https://github-redirect.dependabot.com/grpc/grpc-go/issues/5148">#5148</a>)</li> <li><a href="https://github.com/grpc/grpc-go/commit/75fd0240ac4146e5bcd211e0a3de695ad4369de3"><code>75fd024</code></a> remove sdk term from grpc authz (<a href="https://github-redirect.dependabot.com/grpc/grpc-go/issues/5191">#5191</a>)</li> <li><a href="https://github.com/grpc/grpc-go/commit/a354b1eec35081ebfc7673a7edf273a13a2bfaee"><code>a354b1e</code></a> channelz: rename NewChannelzStorage to NewChannelzStorageForTesting (<a href="https://github-redirect.dependabot.com/grpc/grpc-go/issues/5190">#5190</a>)</li> <li><a href="https://github.com/grpc/grpc-go/commit/0e055491d58ccdd3cb7f30796559a20abfe8d505"><code>0e05549</code></a> Format directory/file references (<a href="https://github-redirect.dependabot.com/grpc/grpc-go/issues/5184">#5184</a>)</li> <li><a href="https://github.com/grpc/grpc-go/commit/c44f627fd1f65c4e9f2837c17b4a734c516172fd"><code>c44f627</code></a> cleanup: replace grpc.WithInsecure with insecure.NewCredentials (<a href="https://github-redirect.dependabot.com/grpc/grpc-go/issues/5177">#5177</a>)</li> <li>Additional commits viewable in <a href="https://github.com/grpc/grpc-go/compare/v1.44.0...v1.45.0">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details>
Adding `CurrentTransferRate ` in the flowrate package because only the status of the transfer rate has been used.
Bumps [github.com/spf13/cobra](https://github.com/spf13/cobra) from 1.3.0 to 1.4.0. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/spf13/cobra/releases">github.com/spf13/cobra's releases</a>.</em></p> <blockquote> <h2>v1.4.0</h2> <h1>Winter 2022 Release ❄️</h1> <p>Another season, another release!</p> <h2>Goodbye viper! 🐍 🚀</h2> <p>The core Cobra library no longer requires Viper and all of its indirect dependencies. This means that Cobra's dependency tree has been drastically thinned! The Viper dependency was included because of the <code>cobra</code> CLI generation tool. <a href="https://github.com/spf13/cobra-cli/releases/tag/v1.3.0">This tool has migrated to <code>spf13/cobra-cli</code></a>.</p> <p>It's <em>pretty unlikely</em> you were importing and using <strong>the bootstrapping CLI tool</strong> as part of your application (after all, it's just a tool to get going with core <code>cobra</code>).</p> <p>But if you were, replace occurrences of</p> <pre><code>"github.com/spf13/cobra/cobra" </code></pre> <p>with</p> <pre><code>"github.com/spf13/cobra-cli" </code></pre> <p>And in your <code>go.mod</code>, you'll want to also include this dependency:</p> <pre><code>github.com/spf13/cobra-cli v1.3.0 </code></pre> <p>Again, the maintainers <em>do not anticipate</em> this being a breaking change to users of the core <code>cobra</code> library, so minimal work should be required for users to integrate with this new release. Moreover, this means the dependency tree for your application using Cobra should no longer require dependencies that were inherited from Viper. Huzzah! 🥳</p> <p>If you'd like to read more</p> <ul> <li>issue: <a href="https://github-redirect.dependabot.com/spf13/cobra/issues/1597">spf13/cobra#1597</a></li> <li>PR: <a href="https://github-redirect.dependabot.com/spf13/cobra/pull/1604">spf13/cobra#1604</a></li> </ul> <h2>Documentation 📝</h2> <ul> <li>Update Go Doc link and badge in README: <a href="https://github-redirect.dependabot.com/spf13/cobra/pull/1593">spf13/cobra#1593</a></li> <li>Fix to install command, now targets <code>@latest</code>: <a href="https://github-redirect.dependabot.com/spf13/cobra/pull/1576">spf13/cobra#1576</a></li> <li>Added MAINTAINERS file: <a href="https://github-redirect.dependabot.com/spf13/cobra/pull/1545">spf13/cobra#1545</a></li> </ul> <h2>Other 💭</h2> <ul> <li>Bumped license year to 2022 in golden files: <a href="https://github-redirect.dependabot.com/spf13/cobra/pull/1575">spf13/cobra#1575</a></li> <li>Added Pixie to projects: <a href="https://github-redirect.dependabot.com/spf13/cobra/pull/1581">spf13/cobra#1581</a></li> <li>Updated labeler for new labeling scheme: <a href="https://github-redirect.dependabot.com/spf13/cobra/pull/1613">spf13/cobra#1613</a> & syntax fix: <a href="https://github-redirect.dependabot.com/spf13/cobra/pull/1624">spf13/cobra#1624</a></li> </ul> <p>Shoutout to our awesome contributors helping to make this cobra release possible!! <a href="https://github.com/spf13"><code>@spf13</code></a> <a href="https://github.com/marckhouzam"><code>@marckhouzam</code></a> <a href="https://github.com/johnSchnake"><code>@johnSchnake</code></a> <a href="https://github.com/jpmcb"><code>@jpmcb</code></a> <a href="https://github.com/liggitt"><code>@liggitt</code></a> <a href="https://github.com/umarcor"><code>@umarcor</code></a> <a href="https://github.com/hiljusti"><code>@hiljusti</code></a> <a href="https://github.com/marians"><code>@marians</code></a> <a href="https://github.com/shyim"><code>@shyim</code></a> <a href="https://github.com/htroisi"><code>@htroisi</code></a></p> </blockquote> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/spf13/cobra/blob/master/CHANGELOG.md">github.com/spf13/cobra's changelog</a>.</em></p> <blockquote> <h1>Cobra Changelog</h1> <h2>v1.1.3</h2> <ul> <li><strong>Fix:</strong> release-branch.cobra1.1 only: Revert "Deprecate Go < 1.14" to maintain backward compatibility</li> </ul> <h2>v1.1.2</h2> <h3>Notable Changes</h3> <ul> <li>Bump license year to 2021 in golden files (<a href="https://github-redirect.dependabot.com/spf13/cobra/issues/1309">#1309</a>) <a href="https://github.com/Bowbaq"><code>@Bowbaq</code></a></li> <li>Enhance PowerShell completion with custom comp (<a href="https://github-redirect.dependabot.com/spf13/cobra/issues/1208">#1208</a>) <a href="https://github.com/Luap99"><code>@Luap99</code></a></li> <li>Update gopkg.in/yaml.v2 to v2.4.0: The previous breaking change in yaml.v2 v2.3.0 has been reverted, see <a href="https://github-redirect.dependabot.com/go-yaml/yaml/issues/670">go-yaml/yaml#670</a></li> <li>Documentation readability improvements (<a href="https://github-redirect.dependabot.com/spf13/cobra/issues/1228">#1228</a> etc.) <a href="https://github.com/zaataylor"><code>@zaataylor</code></a> etc.</li> <li>Use golangci-lint: Repair warnings and errors resulting from linting (<a href="https://github-redirect.dependabot.com/spf13/cobra/issues/1044">#1044</a>) <a href="https://github.com/umarcor"><code>@umarcor</code></a></li> </ul> <h2>v1.1.1</h2> <ul> <li><strong>Fix:</strong> yaml.v2 2.3.0 contained a unintended breaking change. This release reverts to yaml.v2 v2.2.8 which has recent critical CVE fixes, but does not have the breaking changes. See <a href="https://github-redirect.dependabot.com/spf13/cobra/pull/1259">spf13/cobra#1259</a> for context.</li> <li><strong>Fix:</strong> correct internal formatting for go-md2man v2 (which caused man page generation to be broken). See <a href="https://github-redirect.dependabot.com/spf13/cobra/issues/1049">spf13/cobra#1049</a> for context.</li> </ul> <h2>v1.1.0</h2> <h3>Notable Changes</h3> <ul> <li>Extend Go completions and revamp zsh comp (<a href="https://github-redirect.dependabot.com/spf13/cobra/issues/1070">#1070</a>)</li> <li>Fix man page doc generation - no auto generated tag when <code>cmd.DisableAutoGenTag = true</code> (<a href="https://github-redirect.dependabot.com/spf13/cobra/issues/1104">#1104</a>) <a href="https://github.com/jpmcb"><code>@jpmcb</code></a></li> <li>Add completion for help command (<a href="https://github-redirect.dependabot.com/spf13/cobra/issues/1136">#1136</a>)</li> <li>Complete subcommands when TraverseChildren is set (<a href="https://github-redirect.dependabot.com/spf13/cobra/issues/1171">#1171</a>)</li> <li>Fix stderr printing functions (<a href="https://github-redirect.dependabot.com/spf13/cobra/issues/894">#894</a>)</li> <li>fix: fish output redirection (<a href="https://github-redirect.dependabot.com/spf13/cobra/issues/1247">#1247</a>)</li> </ul> <h2>v1.0.0</h2> <p>Announcing v1.0.0 of Cobra. 🎉</p> <h3>Notable Changes</h3> <ul> <li>Fish completion (including support for Go custom completion) <a href="https://github.com/marckhouzam"><code>@marckhouzam</code></a></li> <li>API (urgent): Rename BashCompDirectives to ShellCompDirectives <a href="https://github.com/marckhouzam"><code>@marckhouzam</code></a></li> <li>Remove/replace SetOutput on Command - deprecated <a href="https://github.com/jpmcb"><code>@jpmcb</code></a></li> <li>add support for autolabel stale PR <a href="https://github.com/xchapter7x"><code>@xchapter7x</code></a></li> <li>Add Labeler Actions <a href="https://github.com/xchapter7x"><code>@xchapter7x</code></a></li> <li>Custom completions coded in Go (instead of Bash) <a href="https://github.com/marckhouzam"><code>@marckhouzam</code></a></li> <li>Partial Revert of <a href="https://github-redirect.dependabot.com/spf13/cobra/issues/922">#922</a> <a href="https://github.com/jharshman"><code>@jharshman</code></a></li> <li>Add Makefile to project <a href="https://github.com/jharshman"><code>@jharshman</code></a></li> <li>Correct documentation for InOrStdin <a href="https://github.com/desponda"><code>@desponda</code></a></li> <li>Apply formatting to templates <a href="https://github.com/jharshman"><code>@jharshman</code></a></li> <li>Revert change so help is printed on stdout again <a href="https://github.com/marckhouzam"><code>@marckhouzam</code></a></li> <li>Update md2man to v2.0.0 <a href="https://github.com/pdf"><code>@pdf</code></a></li> <li>update viper to v1.4.0 <a href="https://github.com/umarcor"><code>@umarcor</code></a></li> </ul> </blockquote> <p>... (truncated)</p> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/spf13/cobra/commit/5b2b9e9f61d36ccb66167301f76a2292c3729855"><code>5b2b9e9</code></a> Removes viper dependency by removing cobra/ CLI tool (<a href="https://github-redirect.dependabot.com/spf13/cobra/issues/1604">#1604</a>)</li> <li><a href="https://github.com/spf13/cobra/commit/9369465955fcc766aed3e7cf574277ee553251d4"><code>9369465</code></a> labeler: fix syntax</li> <li><a href="https://github.com/spf13/cobra/commit/e1b831e5c2a1639f3bba57d0922fd0c7a7816df7"><code>e1b831e</code></a> Updates labeler for new labels (<a href="https://github-redirect.dependabot.com/spf13/cobra/issues/1613">#1613</a>)</li> <li><a href="https://github.com/spf13/cobra/commit/8267283cfe84768a0ec01b29b981f37e2ea99299"><code>8267283</code></a> Add MAINTAINERS file (alphabetical order) (<a href="https://github-redirect.dependabot.com/spf13/cobra/issues/1545">#1545</a>)</li> <li><a href="https://github.com/spf13/cobra/commit/6d2dc43606da38b673801b8f678c7e5143dfad58"><code>6d2dc43</code></a> Add Pixie to projects. (<a href="https://github-redirect.dependabot.com/spf13/cobra/issues/1581">#1581</a>)</li> <li><a href="https://github.com/spf13/cobra/commit/a5996323794c96a0d14df49f6675708a87e53b98"><code>a599632</code></a> Fix install command (<a href="https://github-redirect.dependabot.com/spf13/cobra/issues/1576">#1576</a>)</li> <li><a href="https://github.com/spf13/cobra/commit/7cabfeb8f837c7bd5b834f4fbe98fdef1136465a"><code>7cabfeb</code></a> Update Go Doc link and badge (<a href="https://github-redirect.dependabot.com/spf13/cobra/issues/1593">#1593</a>)</li> <li><a href="https://github.com/spf13/cobra/commit/e04ec725508c760e70263b031e5697c232d5c3fa"><code>e04ec72</code></a> Bump license year to 2022 in golden files (<a href="https://github-redirect.dependabot.com/spf13/cobra/issues/1575">#1575</a>)</li> <li><a href="https://github.com/spf13/cobra/commit/cb9d7b1cec87c2bb005c6e2790553bcd629bc542"><code>cb9d7b1</code></a> Bump github.com/spf13/viper from 1.10.0 to 1.10.1 (<a href="https://github-redirect.dependabot.com/spf13/cobra/issues/1567">#1567</a>)</li> <li>See full diff in <a href="https://github.com/spf13/cobra/compare/v1.3.0...v1.4.0">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details>
The PEX reactor has a simple feedback control mechanism to decide how often to poll peers for peer address updates. The idea is to poll more frequently when knowledge of the network is less, and decrease frequency as knowledge grows. This change solves two problems: 1. It is possible in some cases we may poll a peer "too often" and get dropped by that peer for spamming. 2. The first successful peer update with any content resets the polling timer to a very long time (10m), meaning if we are unlucky in getting an incomplete reply while the network is small, we may not try again for a very long time. This may contribute to difficulties bootstrapping sync. The main change here is to only update the interval when new information is added to the system, and not (as before) whenever a request is sent out to a peer. The rate computation is essentially the same as before, although the code has been a bit simplified, and I consolidated some of the error handling so that we don't have to check in multiple places for the same conditions. Related changes: - Improve error diagnostics for too-soon and overflow conditions. - Clean up state handling in the poll interval computation. - Pin the minimum interval avert a chance of PEX spamming a peer.
The message handling in this reactor is all under control of the reactor itself, and does not call out to callbacks or other externally-supplied code. It doesn't need to check for panics. - Remove an irrelevant channel ID check. - Remove an unnecessary panic recovery wrapper.
* Hard-code go_package option for .proto files Signed-off-by: Thane Thomson <connect@thanethomson.com> * Automatically relocate generated ABCI types after proto-gen Signed-off-by: Thane Thomson <connect@thanethomson.com> * Skip building gogoproto (i.e. only build our types) Signed-off-by: Thane Thomson <connect@thanethomson.com> * Remove unnecessary proto generation scripts Signed-off-by: Thane Thomson <connect@thanethomson.com> * Upgrade buf config from v1beta1 to v1 Signed-off-by: Thane Thomson <connect@thanethomson.com> * Add simple proto generation script Signed-off-by: Thane Thomson <connect@thanethomson.com> * Replace buf-based protobuf generation with simple protoc-based approach Signed-off-by: Thane Thomson <connect@thanethomson.com> * Remove custom buf-based Docker image generation config and Dockerfile Signed-off-by: Thane Thomson <connect@thanethomson.com> * Adopt Cosmos SDK's approach to Protobuf linting and breakage checking in CI Signed-off-by: Thane Thomson <connect@thanethomson.com> * Suppress command echo when running proto checks Signed-off-by: Thane Thomson <connect@thanethomson.com> * Fix proto-check workflow YAML indentation Signed-off-by: Thane Thomson <connect@thanethomson.com> * Restore proto-format target Signed-off-by: Thane Thomson <connect@thanethomson.com> * Replace custom BASH script with make equivalent Signed-off-by: Thane Thomson <connect@thanethomson.com> * Remove proto linting/breaking changes CI checks after discussion today Signed-off-by: Thane Thomson <connect@thanethomson.com> * Remove dangling reference to CI workflow that no longer exists Signed-off-by: Thane Thomson <connect@thanethomson.com> * Update contributing guidelines relating to protos Signed-off-by: Thane Thomson <connect@thanethomson.com> * Use buf instead for generating protos Signed-off-by: Thane Thomson <connect@thanethomson.com> * Remove unused buf config for gogoprotobuf Signed-off-by: Thane Thomson <connect@thanethomson.com> * Add reminder for if we migrate fully to buf Signed-off-by: Thane Thomson <connect@thanethomson.com> * Restore protopackage script for #8065 Signed-off-by: Thane Thomson <connect@thanethomson.com> * Fix permissions on protopackage script Signed-off-by: Thane Thomson <connect@thanethomson.com> * Update contributing guidelines to show building of protos using buf Signed-off-by: Thane Thomson <connect@thanethomson.com> * Fix breaking changes check and add disclaimer Signed-off-by: Thane Thomson <connect@thanethomson.com> * Expand on contributing guidelines for clarity Signed-off-by: Thane Thomson <connect@thanethomson.com> * Re-remove old proto workflows Signed-off-by: Thane Thomson <connect@thanethomson.com> * Add buf-based proto linting workflow in CI Signed-off-by: Thane Thomson <connect@thanethomson.com> * Superficially reorder proto targets Signed-off-by: Thane Thomson <connect@thanethomson.com> * Fix proto lints Signed-off-by: Thane Thomson <connect@thanethomson.com> * Fix GA workflow YAML indentation Signed-off-by: Thane Thomson <connect@thanethomson.com> * Temporarily use forked version of mlc Use forked version of markdown-link-check until gaurav-nelson/github-action-markdown-link-check#126 lands. Signed-off-by: Thane Thomson <connect@thanethomson.com> * Temporarily disable markdown link checker Signed-off-by: Thane Thomson <connect@thanethomson.com> * Remove gogo protos - superseded by version from buf registry Signed-off-by: Thane Thomson <connect@thanethomson.com>
Updates #8077. The panic handler for consensus currently attempts to effect a clean shutdown, but this can leave a failed node running in an unknown state for an arbitrary amount of time after the failure. Since a panic at this point means consensus is already irrecoverably broken, we should not allow the node to continue executing. After making a best effort to shut down the writeahead log, re-panic to ensure the node will terminate before any further state transitions are processed. Even with this change, it is possible some transitions may occur while the cleanup is happening. It might be preferable to abort unconditionally without any attempt at cleanup. Related changes: - Clean up the creation of WAL directories. - Filter WAL close errors at rethrow.
Minor Typo (nice doc!)
Add Vocdoni under applications section on the README.
This pull requests adds an RFC to discuss the proposed mechanism for transaction replacement detailed in the ABCI++ specification.
* libs/log: remove Must constructor * Update test/e2e/node/main.go Co-authored-by: M. J. Fromberger <michael.j.fromberger@gmail.com> * use stdlog Co-authored-by: M. J. Fromberger <michael.j.fromberger@gmail.com>
* autofile: reduce minor panic and docs changes * fix lint
shotonoff
force-pushed
the
backport-master
branch
from
ddedfdd
to
cb13d43
Compare
lklimek
requested changes
May 30, 2022
| @@ -3,8 +3,8 @@ package mock | |||
| import ( | |||
| "encoding/binary" | |||
| "encoding/hex" | |||
| "sync" | |||
There was a problem hiding this comment.
This sync package doesn't support deadlock detection feature. Ours did support that (but was a bit broken).
There was a problem hiding this comment.
opened a ticket to rollback this functionality
| // Quorum hash is pseudorandom | ||
| return types.NewValidatorSet( | ||
| res, | ||
| thresholdPublicKey, | ||
| btcjson.LLMQType_5_60, | ||
| crypto.Sha256(thresholdPublicKey.Bytes()), | ||
| crypto.Checksum(thresholdPublicKey.Bytes()), |
There was a problem hiding this comment.
Using generalized Checksum might be dangerous, as if someone in future changes it to sha384, compatibility with formal specification (DIP documents) can be affected. Maybe we should have a specialized function like CalculateQuorumHash, etc?
There was a problem hiding this comment.
I already commented it here
unit-test should help us to prevent a case if the algorithm will be changed
privval/file.go
Outdated
| @@ -833,5 +823,5 @@ func (pv *FilePV) saveSigned( | |||
| pv.LastSignState.BlockSignBytes = blockSignBytes | |||
| pv.LastSignState.StateSignature = stateSig | |||
| pv.LastSignState.StateSignBytes = stateSignBytes | |||
| pv.LastSignState.Save() | |||
| _ = pv.LastSignState.Save() | |||
There was a problem hiding this comment.
We should at least log something on error
There was a problem hiding this comment.
add error return type to propagate error further
| @@ -94,29 +94,6 @@ func TestApp_Height(t *testing.T) { | |||
| }) | |||
| } | |||
|
|
|||
| // Tests that the app and blockstore have and report the same height. | |||
| func TestApp_Height(t *testing.T) { | |||
There was a problem hiding this comment.
after the merge we had some duplications, likely that was one of these.
this code is presented proof
lklimek
approved these changes
Jun 8, 2022
abci/example/kvstore/kvstore.go
Outdated
| @@ -367,7 +366,7 @@ func (app *Application) execValidatorSetTx(tx []byte) error { | |||
| app.valSetUpdate = *vsu | |||
| app.valsIndex = make(map[string]*types.ValidatorUpdate) | |||
| for i, v := range vsu.ValidatorUpdates { | |||
| app.valsIndex[v.String()] = &vsu.ValidatorUpdates[i] | |||
| app.valsIndex[crypto.ProTxHash(v.ProTxHash).String()] = &vsu.ValidatorUpdates[i] | |||
There was a problem hiding this comment.
Can crypto.ProTxHash(v.ProTxHash).String() be simplified?
There was a problem hiding this comment.
only if use a function,
shotonoff
commented
Jun 8, 2022
abci/example/kvstore/kvstore.go
Outdated
| @@ -367,7 +366,7 @@ func (app *Application) execValidatorSetTx(tx []byte) error { | |||
| app.valSetUpdate = *vsu | |||
| app.valsIndex = make(map[string]*types.ValidatorUpdate) | |||
| for i, v := range vsu.ValidatorUpdates { | |||
| app.valsIndex[v.String()] = &vsu.ValidatorUpdates[i] | |||
| app.valsIndex[crypto.ProTxHash(v.ProTxHash).String()] = &vsu.ValidatorUpdates[i] | |||
There was a problem hiding this comment.
only if use a function,
…t-updates item in a storage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
What was done?
How Has This Been Tested?
Breaking Changes
Checklist:
For repository code-owners and collaborators only