Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(types): abci valset update abci does not need a public key on replay #786

Merged
merged 4 commits into from
May 16, 2024

Conversation

lklimek
Copy link
Collaborator

@lklimek lklimek commented May 9, 2024

Issue being fixed or feature implemented

Tenderdash requires validator set updates to contain public keys of all validators.
However, this should not be required, as in some scenarios (like replay) these
pubkeys are not available.

What was done?

Validators in validator set no longer require public key.

How Has This Been Tested?

On testnet, when got the failure, with the following procedure:

dashmate config set --config testnet platform.drive.tenderdash.docker.image dashpay/tenderdash:fix-validator-update-without-pubkey
dashmate stop --platform
dashmate reset --platform
dashmate start --platform

Breaking Changes

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@lklimek lklimek changed the title fix(types): validator update abci msg does not need a public key on r… fix(types): abci valset update abci does not need a public key on replay May 9, 2024
@lklimek lklimek marked this pull request as ready for review May 9, 2024 12:42
@lklimek lklimek enabled auto-merge (squash) May 10, 2024 12:37
types/validator.go Outdated Show resolved Hide resolved
@lklimek lklimek force-pushed the fix/validator-update-without-pubkey branch from 611142d to bbbfb46 Compare May 10, 2024 14:34
@dashpay dashpay deleted a comment from shumkov May 13, 2024
@lklimek lklimek force-pushed the fix/validator-update-without-pubkey branch from bbbfb46 to 7215cd3 Compare May 15, 2024 10:21
@lklimek lklimek disabled auto-merge May 15, 2024 10:35
@lklimek lklimek requested a review from shumkov May 15, 2024 13:08
types/protobuf.go Outdated Show resolved Hide resolved
@lklimek lklimek requested a review from shumkov May 15, 2024 15:17
@shumkov
Copy link
Member

shumkov commented May 16, 2024

Good job!

@lklimek lklimek merged commit 79515d6 into v0.14-dev May 16, 2024
16 checks passed
@lklimek lklimek deleted the fix/validator-update-without-pubkey branch May 16, 2024 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants