-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
optimise linear layer chains #210
Conversation
I suspect this fails when reducing in any layer (i.e,. number of indices decreases), but for the purposes of dask-awkward we might be fine, where there is always one index of iteration: the partition. |
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #210 +/- ##
==========================================
+ Coverage 94.74% 94.88% +0.14%
==========================================
Files 19 19
Lines 2111 2190 +79
==========================================
+ Hits 2000 2078 +78
- Misses 111 112 +1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
(because will never meet one-dep requirement)
related: dask/dask#9795 |
@rjzamora , you might be interested to look at this. It implements a linear-time "fuse" operation on chains of Blockwise layers which is much faster that standard dask's layer fuse for very large numbers of layers. As it stands, the algorithm passes the specific two tests written for it, but causes many other dask-awkward tests to fail. I believe that there are two most likely causes:
Any thoughts you might have on this would be appreciated! |
Good to go? |
As far as I can tell from torture tests, yes! |
No description provided.