feat: support Ellipsis as first arg in multi arg getitem #217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
martindurant
reviewed
Apr 5, 2023
| @@ -892,6 +892,9 @@ def _getitem_tuple(self, where: tuple[Any, ...]) -> Array: | |||
| if issubclass(dtype, (np.bool_, bool, np.int64, np.int32, int)): | |||
| return self._getitem_outer_bool_or_int_lazy_array(where) | |||
|
|
|||
| elif where[0] is Ellipsis: | |||
| return self._getitem_trivial_map_partitions(where) | |||
There was a problem hiding this comment.
Is it not the case that ellipsis can evaluate to zero indices?
There was a problem hiding this comment.
Ah yes for something not deeply nested we can end up with something like
In [25]: a = ak.Array({"x": [1, 2, 3]})
In [26]: a
Out[26]: <Array [{x: 1}, {x: 2}, {x: 3}] type='3 * {x: int64}'>
In [27]: a[..., 0]
Out[27]: <Record {x: 1} type='{x: int64}'>There was a problem hiding this comment.
So we'll need more than just a trivial map partitions call
There was a problem hiding this comment.
This will be what is desired in most sensible user code. We, again, need to know the number of possible axes.
There was a problem hiding this comment.
Right, I think a check on ndim vs len(where) will give us info we need to determine if we're good to use the trivial case
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.