Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: optimize even if we have to make the HLG #465

Merged
merged 1 commit into from
Feb 1, 2024

Conversation

lgray
Copy link
Collaborator

@lgray lgray commented Feb 1, 2024

@martindurant this seems like a bug to me, so I am removing it.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (73c80f8) 93.06% compared to head (7aafd96) 93.06%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #465   +/-   ##
=======================================
  Coverage   93.06%   93.06%           
=======================================
  Files          23       23           
  Lines        3290     3290           
=======================================
  Hits         3062     3062           
  Misses        228      228           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@martindurant martindurant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I suppose you are right. The original thinking was, I think, "well it's not awkward/blockwise, so no opts will help"; but of course there can be elements like that further up the layer stack.

@martindurant martindurant merged commit 8cb8994 into main Feb 1, 2024
25 checks passed
@lgray lgray deleted the lgray/fix-optimize-not-hlg branch February 1, 2024 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants