Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove TPOT-related NumPy restrictions #1142

Merged
merged 6 commits into from
Jun 5, 2023

Conversation

sarahyurick
Copy link
Collaborator

Since EpistasisLab/tpot#1280 was merged, the changes from #1135 can be reverted.

Copy link
Collaborator

@charlesbluca charlesbluca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once a new tpot release is cut, we'll probably also want to bump our tpot min version to avoid pulling in the problematic versions

@sarahyurick sarahyurick changed the title Remove NumPy restrictions Remove TPOT-related NumPy restrictions May 26, 2023
@sarahyurick
Copy link
Collaborator Author

sarahyurick commented May 26, 2023

Not sure what's going on with the 2 failures in the Ubuntu/Python3.8 check: https://github.com/dask-contrib/dask-sql/actions/runs/5094016111/jobs/9157321430?pr=1142

They don't seem to be related to the changes in this PR either? It looks like Pandas is raising the error.

Edit: Since this error doesn't pop up in #1153, I'll need to investigate further.

@codecov-commenter
Copy link

codecov-commenter commented May 26, 2023

Codecov Report

Merging #1142 (3a751d5) into main (830787e) will increase coverage by 0.11%.
The diff coverage is n/a.

❗ Current head 3a751d5 differs from pull request most recent head 32e1849. Consider uploading reports for the commit 32e1849 to get more accurate results

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##             main    #1142      +/-   ##
==========================================
+ Coverage   81.30%   81.42%   +0.11%     
==========================================
  Files          78       78              
  Lines        4414     4414              
  Branches      799      799              
==========================================
+ Hits         3589     3594       +5     
+ Misses        649      640       -9     
- Partials      176      180       +4     

see 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sarahyurick
Copy link
Collaborator Author

Might just wait on #1143

@charlesbluca
Copy link
Collaborator

Looks like the issue here was an incompatibility between numpy=1.24 and pandas=1.4 that only came up when running the tests using a Dask cluster?

Resolved things locally by pinning numpy=1.21.6 in the 3.8 CI environment - since we use it directly in the codebase, would probably be good to have an established minimum version anyways

@sarahyurick
Copy link
Collaborator Author

Thanks @charlesbluca !

@charlesbluca charlesbluca merged commit e36d8e9 into dask-contrib:main Jun 5, 2023
@sarahyurick sarahyurick deleted the np_tpot_fix branch June 7, 2023 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants