-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REVIEW] Fix dynamic_partition_pruning
to handle a single Parquet file
#1280
Conversation
Hi @charlesbluca it looks like the gpuCI failure is unrelated? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #1280 +/- ##
==========================================
- Coverage 85.54% 85.07% -0.47%
==========================================
Files 77 77
Lines 4261 4261
Branches 795 795
==========================================
- Hits 3645 3625 -20
- Misses 447 462 +15
- Partials 169 174 +5 ☔ View full report in Codecov by Sentry. |
dynamic_partition_pruning
to handle a single Parquet filedynamic_partition_pruning
to handle a single Parquet file
Hi @charlesbluca LMK what you think of this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @sarahyurick! Can verify locally that this resolved #1268; is there a trivial way we can add a test around this behavior?
rerun tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @sarahyurick!
Closes #1268