Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REVIEW] Fix dynamic_partition_pruning to handle a single Parquet file #1280

Merged
merged 12 commits into from
Jan 31, 2024

Conversation

sarahyurick
Copy link
Collaborator

Closes #1268

@sarahyurick
Copy link
Collaborator Author

Hi @charlesbluca it looks like the gpuCI failure is unrelated?

@codecov-commenter
Copy link

codecov-commenter commented Dec 15, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (db7931d) 85.54% compared to head (c230395) 85.07%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1280      +/-   ##
==========================================
- Coverage   85.54%   85.07%   -0.47%     
==========================================
  Files          77       77              
  Lines        4261     4261              
  Branches      795      795              
==========================================
- Hits         3645     3625      -20     
- Misses        447      462      +15     
- Partials      169      174       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sarahyurick sarahyurick changed the title Fix dynamic_partition_pruning to handle a single Parquet file [REVIEW] Fix dynamic_partition_pruning to handle a single Parquet file Dec 15, 2023
@sarahyurick
Copy link
Collaborator Author

Hi @charlesbluca LMK what you think of this.

Copy link
Collaborator

@charlesbluca charlesbluca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sarahyurick! Can verify locally that this resolved #1268; is there a trivial way we can add a test around this behavior?

@charlesbluca
Copy link
Collaborator

rerun tests

Copy link
Collaborator

@charlesbluca charlesbluca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sarahyurick!

@charlesbluca charlesbluca merged commit f2025c1 into dask-contrib:main Jan 31, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] dynamic_partition_pruning::read_table errors on single-file Parquet datasets
3 participants